Skip to content
Snippets Groups Projects

Added interactive glyphs.

Open username-removed-187712 requested to merge feature/InteractiveGlyphs into develop

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Added 21 commits:

    • 1caa5118...99addb24 - 20 commits from branch develop
    • cc9cff7e - Merge develop into feature/InteractiveGlyphs
  • Added 4 commits:

    • cc9cff7e...2a9cc724 - 3 commits from branch develop
    • b4515f99 - Merge develop into feature/InteractiveGlyphs
  • added 61 commits

    • b4515f99...010ffe1d - 60 commits from branch develop
    • 096582d0 - Merge develop into feature/InteractiveGlyphs

    Compare with previous version

  • There's a number of bugs in the test module GUI, but we're not testing the module but the glyph, so let's ignore this. The problem with the glypg is the coloring - axis colors are mixed and not consistent with reper and axes cloring policy: x- red, y - green, z -blue.

  • GitLab

    There's a number of bugs in the test module GUI, but we're not testing the module but the glyph, so let's ignore this. The problem with the glypg is the coloring - axis colors are mixed and not consistent with reper and axes cloring policy: x- red, y - green, z -blue.

    — Reply to this email directly or view it on GitLab https://gitlab.com/ICM-VisLab/VisNow/merge_requests/47#note_41423145. You're receiving this email because of your account on gitlab.com. If you'd like to receive fewer emails, you can unsubscribe https://gitlab.com/sent_notifications/REDACTED/unsubscribe from this thread or adjust your notification settings.

    Glyph axes coloring has been chosen deliberately: green is best visible on the black background thus it has been chosen for the "principal axis (normal to plane and line direction to line axis, similarily for 2D glyphs.

  • It seems that there are two aspects of the colouring dilemma:

    First consideration is about the consistency with axis colours which are x-R, y-G, z-B

    Second aspect is related to visibility of the colours. It worth noticing that for publication purposes one often change the VN viewer background colour to white and the blue colour has good visibility in such case.

    Personally, I favour the consistency with axis colours.

  • While testing interactive glyph "building block" using temporary test module, I encountered the following issues:

    • upon module initialisation radius slider are set to 0 which is inconsistent with geometry visible in the viewer

    • in the cases of plane glyph and line glyph axis switching (radio buttons) does not work

    • in the cases of rect and planar line axis switching does not make sense because these two glyphs are contained in xy plane by definition. Axis switching radio buttons should be made invisible

  • Waiting for updates from @knowpl

Please register or sign in to reply
Loading