Refactor FF/Chrome differences

• Use one global Chrome context object to inject our shim over all Chrome functions, including the listener registration. Like the original Chrome object
• The Chrome object queries for FF/Chrome in the beginning.
• Constructs its sub-objects according to FF/Chrome distinction
• Bonus points if it just delegates to native chrome object when it doesn't yet implement the required function/sub-object
• Change all call sites of the chrome object(s) and remove all instances of if (isFirefox)
• Use in AddonOptions, too
• usages in background.js
• usages in TimeKeeper.js
• Add storage.onChanged.addListener
• and tabs.onUpdated.addListener

assigned to @adimit

The many if/elses riht now are terrible design.

changed the description

changed time estimate to 4h

added 4m 8s of time spent

added To Do label

added Wishlist label

changed milestone to %1.0

removed To Do label

mentioned in issue #17 (closed)

marked this issue as related to #17 (closed)

mentioned in issue #21

added To Do label

added Doing and removed To Do labels

marked the checklist item Use one global Chrome context object to inject our shim over all Chrome functions, including the listener registration. Like the original Chrome object as completed

marked the checklist item Use in AddonOptions, too as completed

added 34m 18s of time spent

added 19m 25s of time spent

marked the checklist item Constructs its sub-objects according to FF/Chrome distinction as completed

marked the checklist item The Chrome object queries for FF/Chrome in the beginning. as completed

changed the description

mentioned in issue #23 (closed)

marked this issue as related to #23 (closed)

added 20m 13s of time spent

changed the description

added 36m 52s of time spent

Bonus points are for nerds. Out of scope:

• it just delegates to native chrome object when it doesn't yet implement the required function/sub-object

mentioned in merge request !2 (merged)

closed via merge request !2 (merged)

added 15m of time spent

marked the checklist item Bonus points if it just delegates to native chrome object when it doesn't yet implement the required function/sub-object as completed

marked the checklist item Bonus points if it just delegates to native chrome object when it doesn't yet implement the required function/sub-object as incomplete

marked the checklist item Change all call sites of the chrome object(s) and remove all instances of if (isFirefox) as completed

marked the checklist item usages in background.js as completed

marked the checklist item usages in TimeKeeper.js as completed

marked the checklist item Add storage.onChanged.addListener as completed

marked the checklist item and tabs.onUpdated.addListener as completed

mentioned in issue #27

marked this issue as related to #27