Skip to content

Add ABORT keyword argument to SB-BSD-SOCKETS:SOCKET-CLOSE

username-removed-975496 requested to merge (removed):develop into develop

This keyword argument was added in SBCL in 2010 and is used to pass ABORT to CL:CLOSE.

The absence of this would obviously cause errors when code expects this to be available. For example, this happens in usocket's SOCKET-CONNECT and would cause several errors in their test suite with obscure error messages like

Wrong number of arguments passed to function #<compiled-function 0000000003562e80>.

I discovered this while investigating issue #204. This commit doesn't allow usocket's test suite to pass, but it does give 4 fewer failed tests for me on OpenBSD and Linux.

Let me know if you would like me to do any further testing before merging.

This is untested on Windows (part of it touches the wsock portion of code). I don't currently have Windows box to test on.

Merge request reports