Update notifications never appear
@pserwylo, assigning you since you reworked much of the UpdateService and before it worked ;) But really, I looked at it and found some other bugs while at it, but couldn't figure this one out yet.
Situation: updates tab says there are updates, but you never get notified. @CiaranG ran real tests with his repos and confirms that it isn't working.
I tried to simulate it by using downloader.setETag("foo");
in updater/RepoUpdater.java, so that it thinks that the index is always new. That seems to work.
Now we get to the bug. updateCount is always zero. I don't think that setEtag above caused this, but rather that this is the source of the issue.
Setting to milestone 0.66 as this is a blocker for a stable (even though this is already broken in 0.63, we want to fix it).