Crash of F-Droid while updating Stringlate app

• Device OS and version: Android 7.1.1 (LineageOS 14.1)
• Device model/manufacturer: OnePlus One (A0001)
• F-Droid version (in the About screen): 0.102.1/102.3

When I try to update Stringlate from version 0.9.9 to 0.9.10 F-Droid crashes immediately. Here is the log sent to reports@f-droid.org:

BRAND=oneplus
ANDROID_VERSION=7.1.1
CUSTOM_DATA=
PHONE_MODEL=A0001
APP_VERSION_NAME=0.102.1
STACK_TRACE=java.lang.RuntimeException: Unable to start activity ComponentInfo{org.fdroid.fdroid/org.fdroid.fdroid.installer.DefaultInstallerActivity}: java.lang.RuntimeException: PackageInstaller >= Android N only supports content scheme!
at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:2665)
at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:2726)
at android.app.ActivityThread.-wrap12(ActivityThread.java)
at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1477)
at android.os.Handler.dispatchMessage(Handler.java:102)
at android.os.Looper.loop(Looper.java:154)
at android.app.ActivityThread.main(ActivityThread.java:6126)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:886)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:776)
Caused by: java.lang.RuntimeException: PackageInstaller >= Android N only supports content scheme!
at org.fdroid.fdroid.installer.DefaultInstallerActivity.installPackage(DefaultInstallerActivity.java:85)
at org.fdroid.fdroid.installer.DefaultInstallerActivity.onCreate(DefaultInstallerActivity.java:65)
at android.app.Activity.performCreate(Activity.java:6679)
at android.app.Instrumentation.callActivityOnCreate(Instrumentation.java:1119)
at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:2618)
... 9 more
java.lang.RuntimeException: PackageInstaller >= Android N only supports content scheme!
at org.fdroid.fdroid.installer.DefaultInstallerActivity.installPackage(DefaultInstallerActivity.java:85)
at org.fdroid.fdroid.installer.DefaultInstallerActivity.onCreate(DefaultInstallerActivity.java:65)
at android.app.Activity.performCreate(Activity.java:6679)
at android.app.Instrumentation.callActivityOnCreate(Instrumentation.java:1119)
at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:2618)
at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:2726)
at android.app.ActivityThread.-wrap12(ActivityThread.java)
at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1477)
at android.os.Handler.dispatchMessage(Handler.java:102)
at android.os.Looper.loop(Looper.java:154)
at android.app.ActivityThread.main(ActivityThread.java:6126)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:886)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:776)

I have updated F-Droid client to version 102.3 but none has changed.

@Etua Looks like an issue with the Stringlate app.

In my logcat I caught an error that ARCA didn't:

04-16 19:05:20.786 20660 20720 E Installer: Permissions in APK and index.xml do not match!
04-16 19:05:20.786 20660 20720 E Installer: org.fdroid.fdroid.installer.ApkVerifier$ApkPermissionUnequalException: Permissions in APK and index.xml do not match!
04-16 19:05:20.786 20660 20720 E Installer: 	at org.fdroid.fdroid.installer.ApkVerifier.verifyApk(ApkVerifier.java:85)
04-16 19:05:20.786 20660 20720 E Installer: 	at org.fdroid.fdroid.installer.Installer.installPackage(Installer.java:234)
04-16 19:05:20.786 20660 20720 E Installer: 	at org.fdroid.fdroid.installer.InstallerService.onHandleIntent(InstallerService.java:77)
04-16 19:05:20.786 20660 20720 E Installer: 	at android.app.IntentService$ServiceHandler.handleMessage(IntentService.java:68)
04-16 19:05:20.786 20660 20720 E Installer: 	at android.os.Handler.dispatchMessage(Handler.java:102)
04-16 19:05:20.786 20660 20720 E Installer: 	at android.os.Looper.loop(Looper.java:154)
04-16 19:05:20.786 20660 20720 E Installer: 	at android.os.HandlerThread.run(HandlerThread.java:61)
04-16 19:05:20.786 20660 20720 E Installer: Falling back to AOSP DefaultInstaller!

added bazaar bug labels

changed milestone to %0.103 - UX Overhaul

assigned to @cde

@eighthave @cde I captured the permission mismatch:

04-17 15:59:11.391  3150  3150 D InstallManagerService: download completed of https://f-droid.org/repo/io.github.lonamiwebs.stringlate_991.apk to file:///data/user/0/org.fdroid.fdroid/cache/apks/f-droid.org--1/io.github.lonamiwebs.stringlate_991.apk
04-17 15:59:11.411  3150  3371 D InstallerFactory: privileged extension correctly installed -> PrivilegedInstaller
04-17 15:59:11.411  3150  3371 D ApkVerifier: localApkUri.getPath: /data/user/0/org.fdroid.fdroid/cache/apks/f-droid.org--1/io.github.lonamiwebs.stringlate_991.apk
04-17 15:59:11.441  3150  3371 D ApkVerifier: Checking permissions
04-17 15:59:11.441  3150  3371 D ApkVerifier: Actual:
04-17 15:59:11.441  3150  3371 D ApkVerifier:   android.permission.INTERNET
04-17 15:59:11.441  3150  3371 D ApkVerifier:   android.permission.ACCESS_NETWORK_STATE
04-17 15:59:11.441  3150  3371 D ApkVerifier: Expected:
04-17 15:59:11.441  3150  3371 D ApkVerifier:   android.permission.ACCESS_NETWORK_STATE
04-17 15:59:11.441  3150  3371 D ApkVerifier:   android.permission.READ_EXTERNAL_STORAGE
04-17 15:59:11.441  3150  3371 D ApkVerifier:   android.permission.INTERNET

I'll bet this has something to do with the fact that android.permission.READ_EXTERNAL_STORAGE used to be automatic, so it didn't need to be in AndroidManifest.xml.

I understand everything now. <uses-permission maxSdkVersion="21" name="android.permission.WRITE_EXTERNAL_STORAGE"/> is correctly in the repo, but not the inherited READ_EXTERNAL_STORAGE.

@eighthave @cde @Etua Looks like a bug in aapt to me... See that:

michel@debian:/tmp/michel/www/repo$ aapt dump badging io.github.lonamiwebs.stringlate_991.apk | grep uses-permission
uses-permission: name='android.permission.INTERNET'
uses-permission: name='android.permission.ACCESS_NETWORK_STATE'
uses-permission: name='android.permission.WRITE_EXTERNAL_STORAGE' maxSdkVersion='21'
uses-permission: name='android.permission.READ_EXTERNAL_STORAGE'

@mimi89999 Actually that looks right.

According to what @eighthave said, which is also documented at https://developer.android.com/reference/android/Manifest.permission.html#READ_EXTERNAL_STORAGE

Any app that declares the WRITE_EXTERNAL_STORAGE permission is implicitly granted this permission.

@cde No, it should be:

uses-permission: name='android.permission.INTERNET'
uses-permission: name='android.permission.ACCESS_NETWORK_STATE'
uses-permission: name='android.permission.WRITE_EXTERNAL_STORAGE' maxSdkVersion='21'
uses-permission: name='android.permission.READ_EXTERNAL_STORAGE' maxSdkVersion='21'

Right, I do agree about that.

One more thing, there's two bugs here.

1. What @mimi89999 is investigating, READ_EXTERNAL_STORAGE.
2. The AOSP DefaultInstaller fallback failing on >= N, since it needs a content URI.

While we workaround / fix 1, we should also fix 2 to make sure the fallback works whenever required.

https://github.com/LonamiWebs/Stringlate/pull/100 Now aapt reports:

michel@debian:~/git/Stringlate$ aapt dump badging src/app/build/outputs/apk/app-debug.apk | grep uses-permission
uses-permission: name='android.permission.INTERNET'
uses-permission: name='android.permission.ACCESS_NETWORK_STATE'
uses-permission: name='android.permission.WRITE_EXTERNAL_STORAGE' maxSdkVersion='21'
uses-permission: name='android.permission.READ_EXTERNAL_STORAGE' maxSdkVersion='21'

That should fix 1. At least for that app.

mentioned in merge request !482 (merged)

!482 (merged) addresses the (2) above, AOSP DefaultInstaller fallback failing on N.

changed milestone to %1.0

Since the only remaining issue here is not directly related to the client, but rather aapt related / server side, should we close / move this issue?

@cde Or rename?

@mimi89999 Yes, by moving I meant fdroidserver, which would also warrant a rename.

@cde So I am for it. BTW, Google still hasn't replied to my issue.