Skip to content

Fix 560 (searching only whitespace)

username-removed-25042 requested to merge pserwylo/fdroidclient:fix-560--searching-only-whitespace into master

When no keywords to search, use an empty query selection that evaluates to "1".

This means that instead of building invalid SQL such as WHERE (() OR ()) it will build WHERE((1) OR (1)) which, while non-optimal, is at least valid. In fact, I'm not even sure that it is non optimal because I'd hope the sqlite query optimizer is able to realise that 1 OR 1 is effectively a no-op.

Fixes issue #560 (closed).

Merge request reports