Skip to content

Installer manager cosmetic changes

username-removed-25042 requested to merge pserwylo/fdroidclient:installer-manager-cosmetic-changes into master

This branch as some cosmetic code changes related to the InstallManagerService. I have a few more that I'll be throwing in here too as I go along. By and large, it is renaming, annotating, minor refactoring. The semantics should not change at all with this change, any fixes to the InstallManagerService will be done through separate MRs. They are from issues listed in this comment during my CR and testing of !278 (merged).

I realise that cosmetic changes often come with baggage because we all have slightly different ideas of what Java code should look like, but in general, I will strive to only make changes if I believe strongly that they will:

  • Improve understanding of the code (i.e. renaming, extracting methods)
  • Prevent future errors by new contributors (e.g. @NonNull/@nullable annotations, extracting classes to encapsulate logic which requires developers to know they need to change multiple things at once)

I try not to make changes because:

  • I have a different opinion about formatting.
  • Hopefully any other unreasonable or disagreeable reason.

Merge request reports