Skip to content

Ask for all fields from the content provider.

username-removed-25042 requested to merge pserwylo/fdroidclient:fix-685--downloading-unknown into master

To be cherry-picked into master as well as this merge into stable-v0.100

Fixes #684 (closed).

fixed

Ask for all fields from the ContentProvider.

It is not a particularly expensive operation in the scheme of things. When we are going to the database, the bottlneck is in disk access for the actual query of the database tables (looking up indexes, performing joins, etc). The difference between retrieving two columns or all the columns when the query is for a handful of apps is inconsequential.

Thus, it is better to be safe than sorry and just ask for all the things so that our value objects are correctly populated. There are indeed suitable times to only request specific fields, but I'd suggest that they are probably only when we need to ask a question about thousands of apps at a time, and then the heap space becomes a concern.

Merge request reports