System app uninstall prevention, fixes crash.

Don't try to uninstall system apps.

Also fix a possible oversight in AppDetails2, which lead to a crash.

Part of https://gitlab.com/fdroid/fdroidclient/issues/740#note_27512923 - just the linked comments (uninstall system apps) are addressed here.

WIP label is due to inline comments above.

mentioned in issue #985 (closed)

mentioned in merge request !500 (merged)

The WIP here at this point is making sure the uninstall upgrades part works and doesn't cause any crashes either, since otherwise there wouldn't be any point in merging this MR - fix one crash, one more is waiting.

changed the description

unmarked as a Work In Progress

changed title from WIP: System app uninstall fixes to System app uninstall prevention, fixes crash.

Updated it to disallow updating system apps, because that was starting to become too complex for too little gain.

One concern right now would be this completely removes the uninstall button for system apps, which might be confusing / need a short explanation somewhere. Thoughts?

Good test case: UnifiedNlp on phone with Google Apps, or Privileged Extension if that is installed as a system app.

We need to support updating system apps, and that is working now. We can survive for now without the ability to uninstall system apps.

Yes, that works just fine, this only touches the uninstall code, and I did just verify that.

Notes For future reference, when somebody wants to improve this:

We can check for updated system apps by checking for ApplicationInfo.FLAG_UPDATED_SYSTEM_APP in isUninstallable(). See https://gitlab.com/fdroid/fdroidclient/commit/2d1ef58ad055093ccace7ceee7050d11e701b479

The button could be changed to say 'uninstall updates', and we also need to handle the case where we can't uninstall the update for some reason (Happened with unifiednlp/gms, logs say it was because app was installed by the play store - installer package name)

Bsides that one comment, this looks ready to go.

resolved all discussions

changed milestone to %1.0

added bazaar label

merged

mentioned in issue #1073