Skip to content
Snippets Groups Projects

convert all relevant <string> to <plurals>

Merged username-removed-24982 requested to merge eighthave/fdroidclient:ever-more-l18n into master
All threads resolved!

For many languages, it is really important to have proper plural support, and its nice in English too :wink:

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Think this is a good change. However it is a pretty blunt solution to delete all the old translations.

    Pros:

    • Technically it is easier for us.
    • Weblate may do the right thing and prompt to add back the newly-pluralised translations.
    • Will force the plurals to be correct once they are added back by translators via Weblate.

    Cons:

    • Weblate may get confused having a string change to a plural.
    • We are asking translators of nearly 50 languages to redo translations they have already done.
    • Trading off a small amount of work for us (replacing <string ...> with <plural ...>) for a small amount of work by lots of different translators. If these turn out to be non sensical (e.g. the equivalent of "1 updates available") then they will only be as nonsensical as they were before you pluralised them.

    On balance, probably best to just nuke the translations and see what weblate does. But to make it more likely to work (and seeing as you need to make a change anyway), can we change the name of the string form notification_summary_updates to something else so Weblate thinks they are different?

  • Deleting the old translations was a deliberate move to reduce confusion and work. The old translations for this will not be of much use. The translators need to stop and think about all the cases. Keeping the old string will just add confusion. These are not long strings, we're asking the translators to do a couple minutes of work.

    Weblate should sync its representation to the source file. If it can't handle the transition of a given key from string to plurals, that's a bug in weblate.

  • username-removed-24982 resolved all discussions

    resolved all discussions

  • Please register or sign in to reply
    Loading