Skip to content

Don't try to notify the user for apks which are already installed.

username-removed-25042 requested to merge pserwylo/fdroidclient:fix-fdroid-notifying-itself into master

I tried to fix the "F-Droid continually notifies about itself wanting to update" in 0.104 with this commit. However that didn't work and it has been reported again (via IRC, and also from my wife). I think the problem was trying to fix it in InstalledAppProviderService whereas the notification which is coming up in 0.104 is coming from AppUpdateStatusService. Both are started by FDroidApp.onCreate(), and there is likely a race condition which is always won by AppUpdateStatusService.

The fix from before is still correct, so doesn't need to be reverted. However this fix hopefully also makes sense.

It works by not notifying people for apks which are already installed with the same hash.

Merge request reports