"AUM:Version +- %v" broken -- suffix operator should not be used as part of suffix
While I never ever used +- syntax as described in https://f-droid.org/manual/html_node/Auto-Update-Mode.html#Auto-Update-Mode, a recent submission tries to use it. While I still am not sure, what it should accomplish, looking at the results makes it clear that there is something going wrong:
#Actual result for: Version -fdroid v%v
Build:1.0.8,1
commit=-fdroid v1.0.8
submodules=yes
gradle=yes
#Actual result for: Version +fdroid v%v
Build:1.0.8+fdroid,2
commit=v1.0.8+fdroid
submodules=yes
gradle=yes
#Actual result for: Version +-fdroid v%v
Build:1.0.8+-fdroid,3
commit=v1.0.8+-fdroid
submodules=yes
gradle=yes
Reading the manual, my expected results would have been:
#Expected result for: Version -fdroid v%v
#(Since `-` is not the suffix operator, it would not update the version and the tag will be just a string
# with %v substituted.)
Build:1.0.8,1
commit=-fdroid v1.0.8
submodules=yes
gradle=yes
#Expected result for: Version +fdroid v%v
#(We have a suffix called `fdroid`, the operator should not be part of the suffix. If we wanted that,
# we had to use `++fdroid` instead. Note the difference to `Version v%vfdroid` which should use the
# same commit/tag, but the version would still be 1.0.8)
Build:1.0.8fdroid,2
commit=v1.0.8fdroid
submodules=yes
gradle=yes
#Expected result for: Version +-fdroid v%v
#(As already said, I dont expect the operator be part of the suffix at all.)
Build:1.0.8-fdroid,3
commit=v1.0.8-fdroid
submodules=yes
gradle=yes
Also I am actually not sure if we really want to the suffix be included in the commit. I rather would have the possibility to manipulate version and commit strings seperately.