support `fdroid build` for CI and dev builds

It is to be expected that --no-refresh does not refresh the git repo, so it can be used for testing. But running the command with --no-refresh does indeed:

	DEBUG: > git rev-parse --show-toplevel
	DEBUG: > git submodule foreach --recursive git reset --hard
	DEBUG: > git submodule foreach --recursive git clean -dffx
	DEBUG: > git fetch origin
	DEBUG: > git fetch --prune --tags origin
	DEBUG: > git remote set-head origin --auto
	DEBUG: > git checkout -f HEAD

which is very much a refresh.

Further details of the problem: I've added an f-droid-build to the CICD builds of my app. It uses the gitlab ci mechanism. You can find the failed build here https://gitlab.com/ar-/apple-flinger/-/jobs/33773929 . The corresponding yaml file is here: https://gitlab.com/ar-/apple-flinger/blob/5ecfddefa4036bf1bcad5e48c53cbe2c23e0cfb8/.gitlab-ci.yml . There you can see the individual steps. It uses the latest master build of fdroidserver and fdroiddata. Then runs a normal fdroid build of my app, then replaces the upstream with the new feature and runs an fdroid build again. unfortunately it is being replaced by the upstream again, even though using --no-refresh.

changed milestone to %1.0

assigned to @eighthave

--no-refresh is operating as designed there, but perhaps its not the best name for that function. It is referring to refreshing the git repo from canonical one on the internet: "Don't refresh the repository, useful when testing a build with no internet connection." It does still do clean/reset, as you can see.

But I think your use case is important to support, we just need to figure out how best to do that. First, I think you'll want to try including .fdroid.yml in your app's git repo. That's the same file as metadata/com.gitlab.ardash.appleflinger.android.

Right now, fdroid build assumes that it will only build commits that are described in the metadata file (either .fdroid.yml or metadata/com.gitlab.ardash.appleflinger.android). Seems like at the very least we want a mode were fdroid build will build the current HEAD of git.

changed title from fdroid build -v --no-refresh is acutually refreshing to {+support fdroid build for CI and dev builds+}

There is also a bug in --no-refresh. fdroid build --no-refresh only affects the lines below, which in your case seem to be executing:

git fetch origin
git fetch --prune --tags origin
git remote set-head origin --auto

I tried to reproduce this in eighthave/fdroidserver@eaca20675c45e544f3721d0553bd64ea7e138e29 but it worked fine there...

removed assignee