Skip to content

Don't pass root_dir to scan_source

username-removed-357829 requested to merge mimi89999/fdroidserver:master into master

Fixes this issue on build:

michel@debian:~/git/fdroiddata$ fdroid build -vl eu.siacs.conversations
Clonage dans 'build/eu.siacs.conversations'...
INFO: Building version 1.18.4 (214) of eu.siacs.conversations
INFO: Getting source for revision 1.18.4
INFO: Creating local.properties file at build/eu.siacs.conversations/local.properties
INFO: Cleaned build.gradle of keysigning configs at build/eu.siacs.conversations/build.gradle
INFO: Running 'prebuild' commands in build/eu.siacs.conversations
+ sed -i -e /playstoreCompile/d -e /play-services-gcm/d -e '/maven {/,+2d' build.gradle
INFO: Cleaning Gradle project...
Incremental java compilation is an incubating feature.
:clean
:libs:MemorizingTrustManager:clean

BUILD SUCCESSFUL

Total time: 10.068 secs
INFO: Scanning source for common problems...
ERROR: Could not build app eu.siacs.conversations due to unknown error: Traceback (most recent call last):
  File "/home/michel/git/fdroidserver/fdroidserver/build.py", line 1038, in main
    options.onserver, options.refresh):
  File "/home/michel/git/fdroidserver/fdroidserver/build.py", line 830, in trybuild
    build_local(app, build, vcs, build_dir, output_dir, log_dir, srclib_dir, extlib_dir, tmp_dir, force, onserver, refresh)
  File "/home/michel/git/fdroidserver/fdroidserver/build.py", line 497, in build_local
    count = scanner.scan_source(build_dir, root_dir, build)
TypeError: scan_source() takes 2 positional arguments but 3 were given

INFO: Finished.
INFO: 1 builds failed

Merge request reports