Skip to content

create_metadata: do not skip APK files having no name

username-removed-1409510 requested to merge IzzySoft/fdroidserver:metadata into master

Since a recent update in update.py, it's no longer possible to create Metadata skeletons for apps which have no AppName:

if options.create_metadata:
    if 'name' not in apk:
        logging.error(apk['packageName'] + ' does not have a name! Skipping...')
        continue

For binary repos, this means trouble if such an .apk is encountered – as the maintainer of such a repo usually has not the means of fixing the .apk. That means to either manually create the Metadata file (e.g. by copying another and editing it accordingly – if one has already such one), or not being able to include the .apk.

I'd suggest to make that possible again, as it was possible with previous versions. Optionally, that could be made dependent on another parameter passed (something like -f of --force), but for ease of use I'd rather made that the default – which is done with this MR.

Note that I wasn't able to test these (minor) adjustments due to #343 (closed) (and before you ask: that issue happened also without these changes, with a "clean master branch" – so it's not caused by this).

Merge request reports