'I Have F-Droid' button broken in repo link view

Steps Taken

• I opened a repo link from my email in Chrome
• Tapped on 'Add to F-Droid'
• Tapped on 'I have F-Droid'

I Expected to tap on 'I have F-Droid' and the F-Droid app open to the repositories view with the link auto-populated within the repository address field.

What I saw was the page reload with 'Add to F-Droid' button appearing on the top of the page.

Thanks for reporting this! Unfortunately, I can't really reproduce this right now. Do you maybe have the link to this page available? If not, what is the link behind the 'I have F-Droid' button?

Torsten hi,

I'm still seeing this bug if you open a repo link (from an email) on a mobile device. I tested a new repo link and am seeing the same thing happen if I do indeed have F-Droid already.

Here is the new repo link I tested : http://repomaker.grobox.de/repos/user_44/repo_53/repo?fingerprint=4FF91C742EE5E15720F26FB497181D00F193C4673A02AAC8FE250FE6DB42C504

I will send it in an email so you can test this yourself on a mobile device. Let me know if you need more clarification.

Hi Torsten,

So I have created a new repo to test this bug. Here is the link below. I see the bug happening when I open the link from the email on a mobile device. (I did try testing this on a mobile device that doesn't have F-Droid and I get an error message saying the address is invalid--I have added the screenshot below)

Here is the link to the repo: http://repomaker.grobox.de/repos/user_44/repo_53/repo?fingerprint=4FF91C742EE5E15720F26FB497181D00F193C4673A02AAC8FE250FE6DB42C504

[image: Inline image 1]

Let me know if you need more clarification. Thank you!

Thanks for the clarification @crwinfrey!

If I try this on repomaker.grobox.de on a phone, I am getting a link that looks like this:

fdroidrepo://repomaker.grobox.de/repos/user_44/repo_53/repo?fingerprint=4FF91C742EE5E15720F26FB497181D00F193C4673A02AAC8FE250FE6DB42C504

Notice the difference in the beginning. fdroidrepo:// instead of http://. Are you sure you are getting this right now on the demo side? If yes, what kind of phone are you using?

@tiffrobo thanks for the screenshot. What you are getting is the expected behavior. Repomaker and F-Droid are just for Android. Things won't work on Apple devices.

Totally had a lapse in memory about Repomaker and FDroid not yet being compatible with Apple Devices. Thanks :)

Link I'm getting..

http://repomaker.grobox.de/repos/user_44/repo_53/repo/?fingerprint= 4FF91C742EE5E15720F26FB497181D00F193C4673A02AAC8FE250FE6DB42C504

Tap on link.

Open in Chrome

Tap 'Add to FDroid'

Tap 'I have FDroid'

Screen goes back to ' Add to Fdroid'

Device: Moto G Play

Android Version 6.0.1

Thanks @tiffrobo! Could you please do the following and send me a screenshot from it?

1. Open http://repomaker.grobox.de/repos/user_44/repo_53/repo/ in Chrome on the Moto G Play
2. Tap on Add To F-Droid
3. Long-tap on I Have F-Droid
4. Wait for dialog to popup and then make a screenshot

Here is the screenshot:

Thanks for that! It shows me that the link there is correct. When you don't long-tap it in step three, but only give it a short tap, you say that the screen goes back to ' Add to Fdroid', right?

Is F-Droid installed on that phone?

changed milestone to %1.0

added bazaar bug dev labels

Yes, correct. A short tap goes back to 'Add to FDroid'

Yes, FDroid is installed on this phone.

I tested the option to open the link in a new tab and it opens a new tab, but the page is blank.

Thanks for bearing with me!

I think this is an issue in the F-Droid app. It does not seem to react to the special URL as it should. The reason for this might be that the URL does not include /fdroid/repo/, but just /repo/.

@pserwylo can you confirm this? The matching code is here.

If so, what can we do for F-Droid to recognize all links starting with fdroidrepo:// and fdroidrepos:// independent of the path?

assigned to @pserwylo

mentioned in issue fdroidclient#1171 (closed)

I'll change the client so it takes any fdroidrepo:// intent regardless of path. This seems perfectly reasonable to me and would resolve this issue. It makes even more sense when considering that the Add New Repo functionality tries to help by looking for a repo:

• At the exact URL given by the user,
• If not found, attempts to find one at /fdroid/repo appended to the path given by the user,
• If still not found, tries /repo appended to the path, then gives up.

Tracking in fdroidclient#1171 (closed).

Fixed in fdroidclient!582 (merged)

However there is now a problem whereby the repomaker.grobox.de server (likely since having HTTPS configured) is sending a 301 redirect when asking for index-v1.jar via http. This is related to the clients inability to follow redirects (see fdroidclient#1041). Although I still think we should follow redirects, this may have highlighted a minor bug in repomaker when it tells the user the URL of a repo.

That is, it should ensure that the URL is a https URL if the server is configured with HTTPS, instead of defaulting to HTTP. For reference, if repomaker can fix the http:// URL of a repo to instead be https:// when appropriate, this should just work for the fdroidrepo:// URL (i.e. it will change to an fdroidrepos:// URL) due to the code here.

It ocurred to me the HTTPS problem may be because I created my repo before HTTPS was enabled, which is perfectly understandable (because it has saved the repo URL to the database). However when I create a new repo on repomaker.grobox.de then it also sets its URL to http:// instead of https://.

I'll change the client so it takes any fdroidrepo:// intent regardless of path.

Thanks Peter!

However there is now a problem whereby the repomaker.grobox.de server (likely since having HTTPS configured) is sending a 301 redirect when asking for index-v1.jar via http. This is related to the clients inability to follow redirects (see fdroidclient#1041). Although I still think we should follow redirects, this may have highlighted a minor bug in repomaker when it tells the user the URL of a repo.

I am not sure this is a bug. The reason for this behavior is that we switched to HTTPS recently, but forget to adapt the location of the default storage.

It ocurred to me the HTTPS problem may be because I created my repo before HTTPS was enabled, which is perfectly understandable (because it has saved the repo URL to the database).

Exactly! Currently, we don't support changing these URLs midflight.

However when I create a new repo on repomaker.grobox.de then it also sets its URL to http:// instead of https://.

I have adapted the default storage URL in the config and now new repos have the correct URL.

fdroidclient!582 (merged) got merged and will be part of the next F-Droid Client release. Since this should take care of this issue, I will close this one now. Thanks @crwinfrey and @tiffrobo for getting to the bottom of this!

closed