Separate rspec options with `--`
This lets OptionParser
ignore rspec options
See https://gitlab.com/gitlab-org/gitlab-qa/issues/374
This changes exe/gitlab-qa
so that it inserts a 2nd separator before OptionParser
kicks in. That way we don't have to use commands with multiple separators. I.e., we can just do -- --tag
instead of -- -- --tag
.
This also changes all the scenarios that were running Test::Instance
to use Test::Instance::All
instead because Test::Instance
is obsolete and doesn't handle options like Test::Instance::All
and all the other scenarios now do.
Should be merged with https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/10324 and https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/26060 because they make the QA framework invoke OptionParser
for all scenarios.
See this discussion for test results: https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/26060#note_154022297