Skip to content

Draft: Enable gitaly feature flags by default

George Koltsov requested to merge jmd/gitaly-testing-all-feature-flags into master

What does this MR do and why?

As follow up to https://gitlab.com/gitlab-org/gitlab/-/issues/421712#note_1517496919 it was noted that it may be preferable to run all E2E tests with Gitaly Feature Flags enabled. This will allow us to identify potential regressions when they are introduced, as at the moment, we won't detect issues until the FF is marked as enabled by default.

See internal/featureflag/featureflag.go#L17-26 for implementation details in gitaly.

How to set up and validate locally

  • All tests that interact with either Gitaly/Praefect should succeed

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by George Koltsov

Merge request reports