Skip to content

Extract generic shell command from docker command

George Koltsov requested to merge ml-refactor-shell-command-handling into master

What does this MR do and why?

Extracts the code for executing shell commands from Docker::Shellout to Support::ShellCommand so that it can also be used in non-Docker contexts.

This is needed for the changes in https://gitlab.com/gitlab-org/gitlab-qa/-/merge_requests/1024 (and these changes were originally included in that MR but I split them off to their own MR here).

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by George Koltsov

Merge request reports