Skip to content

Set release version on compnents using GitalyCluster

George Koltsov requested to merge jmd-bug-fix-gitalycluster-release into master

What does this MR do and why?

The release variable currently is not set in two instances where we are using Component::GitalyCluster - that causes it to always default to EE i.e. nightly versions for praefect/gitaly components.
This prevents the tests from having the ability to run against specific releases of GitalyCluster.

This was initially introduced by https://gitlab.com/gitlab-org/gitlab-qa/-/commit/911c84427bbc76f6b09f17c35c7732396b0de5a6#ebab9b4d4194f0ed83c8c7d98e8c51e0e4b8d5bc_67_24

e.g.

➜ bundle exec exe/gitlab-qa Test::Integration::GitalyCluster gitlab/gitlab-ee:15.4.3-ee.0 --no-tests

➜ docker ps 
CONTAINER ID   IMAGE                          ....
4c00d30a5396   gitlab/gitlab-ee:nightly       .... gitaly1
a91e2818c6e1   gitlab/gitlab-ee:nightly       .... gitaly2
e333a494f5b7   gitlab/gitlab-ee:nightly       .... gitaly3
42cf22b92208   postgres:11                    .... postgres
7417aeea2e01   gitlab/gitlab-ee:nightly       .... praefect
4ef251a19d0e   gitlab/gitlab-ee:15.4.3-ee.0   .... gitlab

This fix rectifies that, so providiving the release tag will run both Gitlab and the various Gitaly Cluster components with the specified version.

How to set up and validate locally

  • Verify that using a release version starts ALL gitlab, gitaly and praefect components with the specified version
    bundle exec exe/gitlab-qa Test::Integration::GitalyCluster gitlab/gitlab-ee:15.4.3-ee.0 --no-tests

  • Verify that using a release version EE starts ALL images with nightly
    bundle exec exe/gitlab-qa Test::Integration::GitalyCluster EE --no-tests

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by George Koltsov

Merge request reports