Skip to content

WIP: Wrap note content in details block

George Koltsov requested to merge wrap-report-in-details-block into master

Problem to Solve

I think that the results issues are very content-heavy at times, especially when the test goes from passing to failing several times over.

Currently, all stack traces and errors are printed out by default which can make scrolling and finding something more difficult.

Proposition

We put the error and stacktraces in a <details> block which would render like this, instead.

Screen_Shot_2020-04-15_at_9.39.05_AM

Error
    expected \`#.passed?\` to return true, got false
  
Stacktrace
Failure/Error: expect(show).to public_send("be_#{status}")
  expected `#.passed?` to return true, got false
./qa/specs/features/browser_ui/4_verify/pipeline/create_and_process_pipeline_spec.rb:82:in `block (5 levels) in '
./qa/scenario/actable.rb:16:in `perform'
./qa/specs/features/browser_ui/4_verify/pipeline/create_and_process_pipeline_spec.rb:81:in `block (4 levels) in '
./qa/specs/features/browser_ui/4_verify/pipeline/create_and_process_pipeline_spec.rb:76:in `each'
./qa/specs/features/browser_ui/4_verify/pipeline/create_and_process_pipeline_spec.rb:76:in `block (3 levels) in '
/usr/local/bundle/gems/rspec-retry-0.6.1/lib/rspec/retry.rb:123:in `block in run'
/usr/local/bundle/gems/rspec-retry-0.6.1/lib/rspec/retry.rb:110:in `loop'
/usr/local/bundle/gems/rspec-retry-0.6.1/lib/rspec/retry.rb:110:in `run'
/usr/local/bundle/gems/rspec-retry-0.6.1/lib/rspec_ext/rspec_ext.rb:12:in `run_with_retry'
./spec/spec_helper.rb:69:in `block (2 levels) in '
/usr/local/bundle/gems/rspec-retry-0.6.1/lib/rspec/retry.rb:123:in `block in run'
/usr/local/bundle/gems/rspec-retry-0.6.1/lib/rspec/retry.rb:110:in `loop'
/usr/local/bundle/gems/rspec-retry-0.6.1/lib/rspec/retry.rb:110:in `run'
/usr/local/bundle/gems/rspec-retry-0.6.1/lib/rspec_ext/rspec_ext.rb:12:in `run_with_retry'
/usr/local/bundle/gems/rspec-retry-0.6.1/lib/rspec/retry.rb:37:in `block (2 levels) in setup'
./qa/specs/runner.rb:69:in `perform'
./qa/scenario/template.rb:10:in `block in perform'
./qa/scenario/template.rb:8:in `tap'
./qa/scenario/template.rb:8:in `perform'
./qa/scenario/template.rb:33:in `perform'
./qa/scenario/template.rb:10:in `block in perform'
./qa/scenario/template.rb:8:in `tap'
./qa/scenario/template.rb:8:in `perform'
./qa/scenario/bootable.rb:28:in `launch!'
  

We will still have access to said content, but will not plague the screen space.

Edited by George Koltsov

Merge request reports

Loading