Skip to content

Start the gitaly node in MTLS scenario in background thread

George Koltsov requested to merge jmd-start-mtls-scenario-in-parallel into master

What does this MR do and why?

Taking the same pattern adopted in https://gitlab.com/gitlab-org/gitlab-qa/-/merge_requests/965 start the gitaly container in a thread to minimise the startup time of the scenario.

Example Current Performance
ce:mtls -> Duration: 9 minutes 13 seconds
ee:mtls -> Duration: 12 minutes 7 seconds

With this change
ce:mtls -> Duration: 6 minutes 48 seconds
ee:mtls -> Duration: 7 minutes 40 seconds

How to set up and validate locally

  • Run EE tests 
    bundle exec exe/gitlab-qa Test::Integration::MTLS EE
  • Run CE tests 
    bundle exec exe/gitlab-qa Test::Integration::MTLS CE
  • Run tests with no teardown 
    bundle exec exe/gitlab-qa Test::Integration::MTLS EE --no-teardown
bundle exec exe/gitlab-qa Test::Integration::MTLS CE --no-tests

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by George Koltsov

Merge request reports