Add merge request reviewer label to me, Douwe and Robert
Merge request reports
Activity
\cc @rspeicher @DouweM
@dzaporozhets Is this clear enough? I've reviewed MR's, so I would be a MR reviewer too... but of course not for anything other than the website. Perhaps it is helpful to clarify by writing something like:
"Reviews merge requests for GitLab CE / EE"?\cc @sytses
Edited by Ernst van NieropI thought this was something that all developers were expected to do/be available for?
Edited by Robert Speicher@dzaporozhets Good points from Ernst and Robert. We have people on the core team that can also merge simple stuff. 'Complex merge endboss'?
@ernstvn @rspeicher you are right. Every developer can review and merge code. I want to specify who:
- will review merge request from new developers during their first month
- will review and merge something complex, big or controversial
@sytses so you kinda right. Its more like 'Complex merge endboss'
😃 Should I update merge request with such title?@ernstvn master has three other meanings, one in git, one in gitlab and a non PC one http://www.nytimes.com/2015/12/03/us/harvard-to-discontinue-use-of-house-master-title.html?_r=0
I prefer endboss, we should link it to http://www.urbandictionary.com/define.php?term=endboss&defid=5331178
Edited by Sid Sijbrandij@sytses That is hilarious, thanks for the links.
@rspeicher I suspect that developers on the core team and in the wider community don't read our onboarding handbook, while they too can propose complex merge requests. Assuming that there is a greater probability that the team page is visited, it makes sense to put it there.
Ah, good to know. Thanks @rspeicher . In that case I am fine with your suggestion; let's see what Sytse and Dmitriy think.
mentioned in merge request !1245 (merged)
Since I got no comments further comments I made a new proposal. https://gitlab.com/gitlab-com/www-gitlab-com/merge_requests/1245 I hope you don't mind @rspeicher
mentioned in commit 76f1b90f