Update the Landing Page banner so it doesn't span the full page unless necessary.

Closer to the original design, and personally I prefer it this way.

Before

After

Desktop:

Mobile:

With overflowing text:

cc: @lukebabb @iamphill

@connorshea @iamphill I think we'll have to agree to disagree on this one...having the "hello bar" / banner span the full width gives the page a bit more balance in my opinion. It just feels off when we shorten the width to fit the content.

So my vote is to leave it as-is unless there is a major reason why we want to change it.

However, the banner on mobile looks great!

@lukebabb it's up to you! :)

Initially I wanted to just remove the underline from the text since it looks pretty ugly, in my opinion. The problem with that is the link no longer looked clickable when it was full-width, so I looked at some of your older designs and tried the banner from this one. I think this makes it a lot more obvious that it's clickable and not just "news" or something.

I'm going to agree with @lukebabb on this - in my opinion the bar looks much nicer stretching full width.

Fair enough, should I close this and open a separate merge request to remove the underline and improve the banner on mobile?

I think defer that to @lukebabb as he did the design with an underline.

For mobile though - it could go onto 2 lines because of the content. So we need to be careful with that!

@connorshea perhaps for now we should just look at improving the banner on mobile. While I'm not completely in love with the underline to signify links either, it has been voiced by several stakeholders to keep it simple and have links look like links.

As we further roll out the redesign we can explore alternatives and see how they go over.

@lukebabb to be fair, neither Google nor Wikipedia use underlines for links anymore, except on hover. Although, they have convenience of being able to use blue links, so maybe that's not comparable.

@connorshea yeah that's a good point, but having our text on a purple background makes it tough as we don't want to introduce a rainbow of colors mashing together ;)

We're definitely exploring the use of the underline on hover where it make sense, but I think for the banner we should stick with the good ol' underline for now.

Added Frontend label

@connorshea Thanks for putting this together.

Status changed to closed