Skip to content
Snippets Groups Projects

New releasepost look + Release post 9.0

Merged Dimitrie Hoekstra requested to merge new-releasepost-look into release-9-0
All threads resolved!

Current result (with dummy data):

Desktop view Mobile view
image image

closes #998 (closed)

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Thanks @iamphill! @jivanvl when ready to review, would please assign to Phil, so he can take a look at the frontend? I'll be able to come back here by the end of next week ;)

  • Dimitrie Hoekstra added 2859 commits

    added 2859 commits

    • de64f2c7...02550a40 - 2854 commits from branch master
    • 9c9f38e6 - initial commit, design header stands
    • c5fb47bc - changed author color back
    • f96c3626 - fixed more styling
    • f9ed5799 - additional styling
    • 95219e31 - made stable and improved after rebase

    Compare with previous version

  • added 1 commit

    • 6b7fb2d8 - various css and structure changes, including improved mvp part

    Compare with previous version

  • added 1 commit

    • dbcf96a2 - fixed ce-ee badges placement and titles for smaller screens

    Compare with previous version

  • Personally, I think I'd like to see the CE and EE labels appear to the right of the feature title rather than the left.

    also fixed

  • On the labels topic, should we consider only having an EE label OR adding a .com label? My concern is that having CE and EE labels makes me instantly wonder about GitLab.com. I know that .com runs EE but new users reading this post may not know that right away.

    @JobV what do you think about this?

  • added 1 commit

    • 1d2d1e21 - fixed non centered titles on small screen sizes

    Compare with previous version

  • added 1 commit

    • 30642c81 - added link functionality to mvp's profile page

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • added 1 commit

    • 9ab8a51a - minor image scaling improvement

    Compare with previous version

  • added 1 commit

    • 804e3216 - added flexbox to normal sections, including a way to reverse them for smaller vi…

    Compare with previous version

  • Dimitrie Hoekstra resolved all discussions

    resolved all discussions

  • Dimitrie Hoekstra resolved all discussions

    resolved all discussions

  • Probably has some unnecessary css code in there though, because of the flex box stuff

  • added 1 commit

    • 173b89d6 - updated release post template

    Compare with previous version

  • last major thing to do is fixing the linting errors

    Edited by Dimitrie Hoekstra
  • added 1 commit

    Compare with previous version

  • added 2 commits

    • c2fd6c50 - more lint fixes
    • bed31087 - made example releasepost consistent with template

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • added 2 commits

    • 06170486 - fixed minor nav scaling issue
    • 9fd815ba - vertical alignment issue for both template as well as example post

    Compare with previous version

  • added 1 commit

    • d09094ed - fix extend and important lint errors

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • added 1 commit

    • 6f636e3a - remove space and replace link

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • added 1 commit

    • 57f304b6 - remove unnecessary markdown html tag

    Compare with previous version

  • Dimitrie Hoekstra
  • added 1 commit

    • c83ee88b - fix description and hide by default.. as its only for SEO

    Compare with previous version

  • added 1 commit

    • 7ecf13c9 - remove guest line in meta info

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • added 1 commit

    • bd3a868f - forgot a space before curly bracket

    Compare with previous version

  • @marcia with my last commit, all linting errors should be fixed and a review app of this should appear :smile:

    Please see what you would change iyo and change it :wink: .. Perhaps already pre fill the example post with real content for the 9.0 release.

    cc: @JobV @victorwu

  • assigned to @marcia

  • Dimitrie Hoekstra unmarked as a Work In Progress

    unmarked as a Work In Progress

  • Dimitrie Hoekstra changed title from WIP New releasepost look to New releasepost look + Release post 9.0

    changed title from WIP New releasepost look to New releasepost look + Release post 9.0

  • Thanks @dimitrieh, overall, looking gooooood! \o/ I'll review it thoroughly, and at this point, I'm only concerned about making it easy to reproduce every month, considering the number of hands contributing to them ;) I'll prob gonna have to add some guidance in the template, and/or perhaps in the blog handbook.

    @iamphill would you please review the frontend part? ;) thank you!

  • changed milestone to %9.0

  • Phil Hughes
  • @marcia this can probably considered a different issue, but perhaps its nice to rethink the order in which we layout the information in this particular kind of blogposts. To consider them more as a sort of extended releasenotes.

    See for more info: https://uxdesign.cc/design-better-release-notes-3e8c8c785231#.st7d95llz

    perhaps to clearly instruct we order items by:

    *** NEW ***
    
    *** IMPROVEMENTS ***
    
    *** FIXED ***
    
  • @dimitrieh will you address Phill's review?

  • I want to target the branch release-9-0 from https://gitlab.com/gitlab-com/www-gitlab-com/merge_requests/4780 with the content of this MR

  • @marcia I hoped you would touch some code in this as well (so that's why i left those to you, as you would have to familiarise yourself to the code anyway) :) Otherwise can look at it later tonight perhaps!

    Edited by Dimitrie Hoekstra
  • @dimitrieh I'd love too, but there's too much on my plate already :)

  • I'm tweaking it @dimitrieh :) Committing/pushing shortly.

    Will need your help with the intro block.

    Edited by username-removed-236961
  • added 6 commits

    • a33f5ff4 - improve template
    • e2b87fb6 - improve template (lorem)
    • f33a3ba9 - add hello-word post based on the template
    • b7f5c3d2 - minor changes
    • 1b854f5a - MVP heading: h3 -> h2, cover img note right-aligned
    • a495d81a - add intro and webcast button

    Compare with previous version

  • We'll need to change the title of the post on the blog landing page too:

    Screen_Shot_2017-03-08_at_20.50.28

    It should look like this:

    Screen_Shot_2017-03-08_at_20.51.35

    Better yet:

    Screen_Shot_2017-03-08_at_20.52.12

  • will finish this tomorrow!

  • image

    fixed

  • added 4 commits

    • bcaf31ee - fix small styling erros including wrong centering of intro piece
    • 1eb2a953 - fixed/removed important styling on webcast button
    • ccc8132e - updated release post template
    • a27ff306 - fixed blog list title for releases

    Compare with previous version

  • added 4 commits

    • bcaf31ee - fix small styling erros including wrong centering of intro piece
    • 1eb2a953 - fixed/removed important styling on webcast button
    • ccc8132e - updated release post template
    • a27ff306 - fixed blog list title for releases

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • added 3 commits

    • b712a0f0 - removed auto margin on h1
    • 68a699e2 - fixed > * selector rule in css
    • 802edc18 - replaced media queries + corrected/included bootstrap variables

    Compare with previous version

  • Dimitrie Hoekstra resolved all discussions

    resolved all discussions

  • added 2 commits

    • 668766d9 - fixed weird unnecessary nth css selector
    • 43d06386 - fixed color variable linting error

    Compare with previous version

  • @iamphill could you assign it to @marcia if no further changes are needed? :D she will do the merge in to https://gitlab.com/gitlab-com/www-gitlab-com/merge_requests/4780

  • assigned to @marcia

  • added 1 commit

    • e309a1fa - documented way to add video webcast recording to blogpost if needed/done afterwards

    Compare with previous version

  • added 2 commits

    Compare with previous version

  • added 4 commits

    • 4c920907 - add instructions back, relocate webcast video section
    • 9c04c665 - remove commented section
    • bda86e09 - make the EEP color a little darker
    • 4b593409 - add EES and EEP classes to instructions

    Compare with previous version

  • added 1 commit

    • 7de43ae0 - remove example post (screenshot here: https://gitlab.com/gitlab-com/www-gitlab-c…

    Compare with previous version

  • username-removed-236961 changed target branch from master to release-9-0

    changed target branch from master to release-9-0

  • Final screenshot here: https://gitlab.com/gitlab-com/www-gitlab-com/blob/master/source/images/new-release-post-example.jpg

    Merging into release post 9.0 NOW! \o/

    Thank you all for the awesome work! #teamwork :tada:

    Thanks @dimitrieh for making this happen!! :hearts:

  • mentioned in commit 5def7473

  • @marcia @dimitrieh why this MR has so many changes?

  • Ah maybe it's because it's not merged into master

  • @alfredo1 They appeared as soon as I changed the target branch from master to release-9-0. I don't understand why :thinking: Do you think this can be a bug somehow? Or it's expected?

  • I don't know, probably release-9-0 was outdated and this branch had the latest from master

  • Thanks Alfredo! Yeah, I don't know either. I think it's weird :| Will ask in #questions :)

  • mentioned in issue #998 (closed)

  • Dimitrie Hoekstra mentioned in merge request !4780 (merged)

    mentioned in merge request !4780 (merged)

  • mentioned in issue #1216 (closed)

  • Please register or sign in to reply
    Loading