Downloadable comparison PDFs

Closes #1027

test.pdf

Few things I need to figure out:

• Footer for every page, it seems to only want to download a footer not use a local HTML file. seems I just didn't build the website to have the file available!
• Font weights seem all wrong, but they are set in the CSS correctly. (Is it even using the right font file?!)
• Seems to be breaking onto a new page when it shouldnt be.
• Header on second page. Can do a global header, so maybe we just want the main header repeated throughout?

cc. @scornille @luke

Also need to make it usable for all the other pages as well as include it in the site build.

Just a FYI, have you seen this @iamphill So the design of the page will change soon. Will that affect the PDF?

@scornille depends on how the page is made. Is it best for me to wait for that to be completed?

@regisF what are your thoughts?

@scornille @iamphill thanks for the ping.

As we are moving fast with a redesign, it's better to wait for it to be finalized. However the mechanism to actually generate the PDF should remain the same.

depends on how the page is made

We want to go use a .yml to generate the tables on the fly now. Do you envision a change in how you currently generate the PDF?

@regisF @scornille I think using .yml files should make getting the content into the PDF a lot easier.

I'll hold off finishing this until the comparison pages are complete

I'll put it in the milestone of next week then.

We will have the new structure ready and live this Friday. Then, let's try to have download pages for the week after this.

changed milestone to %Feb 10, 2017

added 1 commit

• e327fb85 - Slight styling improvements

Compare with previous version

@iamphill since this page has already been updated, are you able to please see if we can make it a downloadable PDF?

added 652 commits

• e327fb85...71289c1b - 649 commits from branch master
• b604442f - Downloadable comparison PDFs
• b9a3cd62 - Slight styling improvements
• 9d85e42b - Changed how the pages are generated

Compare with previous version

@regisF ok so i've added in the table & it is currently looking like gitlab-ce-ee-vs-bitbucket-server.pdf

There are a few spacing issues that I need to look at. & for some weird reason the logos aren't in the PDF

gitlabcom-vs-githubcom.pdf is looking better

We need to decide how we are going to generate them. Do we want to do it on every deploy & potentially slow down the deploy? Also not sure whether this will work reliably. Or shall I just make a command that needs to be run whenever someone wants & then have the PDFs checked into git?

cc. @regisF @smcgivern

added 2 commits

• 8d7714b1 - Updated to use comparison table
• acf48135 - Fixed some spacing & logos not showing

Compare with previous version

@iamphill I would lean towards providing a rake task for now, and adding that to the build if it turns out we need it.

added 1 commit

• bff8af59 - Added Rake task

Compare with previous version

added 1 commit

• cff11fca - Added PDFs for now

Compare with previous version

@smcgivern done with bff8af599d28a4b04dd545e909939e6c58b0e42a but it just runs a bash file

@iamphill awesome! That bash script can be converted to Ruby quite easily, but if we don't need it for this MR, I won't hold it up for that.

@smcgivern There is also a rubygem that has the binary for wkhtmltopdf but I couldn't get that working

That's fine, we can just say it's a dependency for these at https://gitlab.com/gitlab-com/www-gitlab-com#install-pdf-dependencies

added 1 commit

• 8116bbb0 - Documentation

Compare with previous version

Added some documentation.

@luke can you have a look at the PDFs here? I've tried to match the design as close as possible, but its tricky.

I also can't get the footer & header to work across different pages, it messes with the PDFs once they are generated

@iamphill is the latest PDF here: https://gitlab.com/gitlab-com/www-gitlab-com/merge_requests/4731#note_23159589?

@luke Yes & they are also checked into this branch.

@regisF See here for the latest updates

@iamphill thanks!

Also, I can check the review app but we don't have download buttons yet apparently.

@regisF Yeah they aren't there yet, I was focusing on getting the PDFs to look nicer, which is much harder than it sounds

@iamphill overall the PDF looks pretty good, I think it serves the purpose well.

The header image needs to be updated to what's currently on /comparison.

I'm not sure we have much control over this, but there are some less than ideal page breaks:

I'm not sure we have much control over this, but there are some less than ideal page breaks

@luke yeah it is super annoying. In order to get the header positioned at the top of the first page I have to remove the page margin which means it has to be removed from all pages, i'll keep looking but I dont think there is a way to add margin per page.

added 1 commit

• d3feb9b8 - Updated PDFs to remove header

Compare with previous version

unmarked as a Work In Progress

@regisF @luke Added download button & updated PDFs.

@iamphill makes sense with the margins and all, regardless the PDF design is super functional IMO.

Is it possible to move the download button and match the original design (solid fill on hover/click)?

added 1 commit

• 0f3c4a98 - Moved the download button

Compare with previous version

@luke ah yeah, i didnt see the original design sorry. Moved

Looks great, thanks @iamphill!

Thanks @luke

@regisF if you are happy, merge away

@iamphill damn. Merge conflicts. Can you solve? I'll merge right away!

added 320 commits

• 0f3c4a98...366c1b22 - 310 commits from branch master
• 9ddafe5a - Downloadable comparison PDFs
• 01b403f1 - Slight styling improvements
• 63928dbb - Changed how the pages are generated
• f4fa84f5 - Updated to use comparison table
• f1b2b6d7 - Fixed some spacing & logos not showing
• e75be0d6 - Added Rake task
• ea9d0fb6 - Added PDFs for now
• dbd31351 - Documentation
• 7ab5d52f - Updated PDFs to remove header
• 4bf630c3 - Moved the download button

Compare with previous version

@regisF Sorted

added 58 commits

• 4bf630c3...54b0fcf8 - 48 commits from branch master
• c2ca6315 - Downloadable comparison PDFs
• a6ceb6b0 - Slight styling improvements
• d4361aa7 - Changed how the pages are generated
• 0a5e96b3 - Updated to use comparison table
• 0191021c - Fixed some spacing & logos not showing
• d252e6c2 - Added Rake task
• 430f9db0 - Added PDFs for now
• 3cf69a1d - Documentation
• dd086020 - Updated PDFs to remove header
• d2747b99 - Moved the download button

Compare with previous version

resolved all discussions

added 1 commit

• 6ee71890 - Adds to source folder instead of folder

Compare with previous version

@regisF changed so that it adds to the right folder

@iamphill merging. Thanks so much!

merged

mentioned in merge request !5977 (merged)