Installation omnibus design update
Merge request reports
Activity
@luke Do you have the logos for the one click section?
@iamphill really sorry for the confusion, this update is simply for the Omnibus package section. I should have excluded the other sections for my mockup as I did not realized they were different than what's currently on https://about.gitlab.com/installation/
Hopefully this doesn't revert too much of the work you've already done.
@luke haha no its cool
i just commented them out so its all good@iamphill screenshots above look good, could you make the pipeline succeed so I can check out the review app when you get a chance?
added 123 commits
- 61ec48e1...6b664337 - 120 commits from branch
master
- d7e915d4 - Installation omnibus design update
- 08a2eb1c - Open distro content with current hash
- c46187e3 - added one-click methods
Toggle commit list- 61ec48e1...6b664337 - 120 commits from branch
added 123 commits
- 61ec48e1...6b664337 - 120 commits from branch
master
- d7e915d4 - Installation omnibus design update
- 08a2eb1c - Open distro content with current hash
- c46187e3 - added one-click methods
Toggle commit list- 61ec48e1...6b664337 - 120 commits from branch
added 123 commits
- 61ec48e1...6b664337 - 120 commits from branch
master
- d7e915d4 - Installation omnibus design update
- 08a2eb1c - Open distro content with current hash
- c46187e3 - added one-click methods
Toggle commit list- 61ec48e1...6b664337 - 120 commits from branch
added 123 commits
- 61ec48e1...6b664337 - 120 commits from branch
master
- d7e915d4 - Installation omnibus design update
- 08a2eb1c - Open distro content with current hash
- c46187e3 - added one-click methods
Toggle commit list- 61ec48e1...6b664337 - 120 commits from branch
@joshlambert see here for merge request & review app
Thanks @iamphill! Looks pretty good. One item I saw was the dedicated "Update your GitLab instance" section. That is not there on the current Installation page, is it intended to add or was that a screen shot from the old installation page as mentioned above. (https://gitlab.com/gitlab-com/www-gitlab-com/merge_requests/6107#note_30350636)
@joshlambert I'm not sure when / why / how the dedicated "Update your GitLab instance" section was removed from the current installation page. AFAIK it's meant to be there, based on the original redesign request I had for the page. Interestingly there is an "Update GitLab" tile in the
Other official installation methods
section, we should have one or the other, I would argue for having the dedicated section over the tile.@iamphill this is looking great! A couple tweaks...I know some of these were implemented by others, but figured we could make the changes while we are here
-
Checkout the Sketch spec preview for spacing, particularly the distance from the distro-content container and the text inside. Should be 80px left / right and 40px top / bottom.
-
Also check styling for
Community Edition | Troubleshooting | Manual installation
at the bottom. -
Once the disto-content is open, can we make it so clicking on the distro-tile again collapses the install instructions?
-
Fix styling of the
View third-party applications
button at the bottom of the page to match the buttons elsewhere on the page. -
GitLab China Mirror
SVG should have a fill of#444444
-
Can we scale up the
GitLab Juju
logo to better match the size of those around it? -
GitLab Pivotal Tile
- part of the logo is the correct fill#444444
, but the left part is a darker black. -
Update your GitLab instance
section - check theLatest release...
font-color, it looks darker compared to the other#444444
text. -
Lastly, can we make it so the anchor tags for the distro-content containers lands somewhere about here (gives better context around which distro you clicked on):
versus here (currently):
-
@luke That was done intentionally here: https://gitlab.com/gitlab-com/www-gitlab-com/merge_requests/6056
Edited by Joshua LambertCan we scale up the
GitLab Juju
logo to better match the size of those around it?Looks like this is how the SVG already is
can you resize it your end?@joshlambert @luke Whats the decision on the update tile? Keep or remove? If we keep, shouldn't it have the new GitLab logo & not the old?
@iamphill give this SVG a try for
GitLab Juju
: juju-logo.svg@joshlambert makes sense
removed the section@luke thanks! Works great
Anything else from your side?@iamphill looking good! Last thing - can we swap out the Pivotal Cloud Foundry logo with this one: pcf-logo.svg
I cleaned it up a bit and should now display as one solid fill color.
@luke sorted
LGTM @iamphill, thanks for your great work!assigned to @annabeldunstone
@joshlambert I think @annabeldunstone is reviewing the changes, if all is good then we can merge.
- Resolved by Phil Hughes
- Resolved by Annabel Gray
@iamphill this looks great! I've got a couple questions that just need clarification, otherwise it's good to go!
assigned to @iamphill
Great catch on mobile @annabeldunstone
Less padding on the content panes on "tablet" browser size would be nice as well.
assigned to @annabeldunstone
LGTM! Thanks @iamphill
mentioned in commit 57369cee
mentioned in merge request !6360 (merged)