Add themes (embedded in) to production engineers

RFC @ernstvn

closes https://gitlab.com/gitlab-com/infrastructure/issues/2086

cc/ @gl-infra

@pcarranza can we rename "embedded in" to "embedded with"?

We should also define what it means to be embedded. For instance, I think it should mean:

• You participate in team calls for the team that you are embedded with.
• It does not mean that you no longer participate in general Production team issues, fires, calls. In fact, those will still be your priority unless the Lead says otherwise.
• You can be embedded with more than one team at a time, it depends on the level of involvement that is needed.
• You still report to the Production Lead and participate in the Production team meetings
• The point of being embedded with is that you spend time with that team to make their feature set or service "production ready". Since in our case these things are mostly already in production, then it means that you work on making sure that post factum the feature set or service meets the requirements written in the production readiness review questionnaire. This ends with the runbooks and documentation, alerting, monitoring etc being so good that any other member of the Production Team can tend to the feature set or service as well and the "embedment" stops. At that point we name you an expert in the respective service.

Thoughts?

assigned to @pcarranza

added 1 commit

• 2d741f49 - Changed from embedded_in to embedded_with

Compare with previous version

@ernstvn it makes sense to me, I did the first part.

I'll add the "embedded with" to the production engineering page.

assigned to @ernstvn

@ernstvn can I haz review?

added 1 commit

• 8427c29f - Add node of what embedded with means

Compare with previous version

changed the description

resolved all discussions

added 1 commit

• cd43064a - Removed bogus line

Compare with previous version

resolved all discussions

added 63 commits

• cd43064a...8207f02b - 61 commits from branch master
• c901ac4d - Edits to description of what it is to be embedded and fixed typo
• b65e1c27 - Merge branch 'master' into pc-add-themes-to-prod-engs

Compare with previous version

Vini, vidi, conlationes quidam fecit, congruet

enabled an automatic merge when the pipeline for b65e1c27 succeeds

Thanks @pcarranza , please advertise on the team call :-)

Hmmm... non congruet after all. The rspec portion of the pipeline is failing... perhaps it does not like the embedded_with tag?

@pcarranza please take a look and fix, and then feel free to merge.

assigned to @pcarranza

resolved all discussions

@pcarranza The spec is failing because we added an infrastructure project entry, but no corresponding definition in data/projects.yml.

Fixed, thanks @rspeicher

added 1 commit

• 5db72282 - Add infrastructure as a project and some changes to the team

Compare with previous version

assigned to @ernstvn

@pcarranza I'm already merging, but now realizing we should add a link to the respective team page in the handbook, e.g. handbook/infrastructure/security in this case.

On that note, @stanhu where should we link to for the Search "team"? And who is a part of it... I suspect @nick.thomas is?

Shouldn't we be more specific and say something like "Elasticsearch experts"? There is no Search team yet.

I think that the feature is Search, elasticsearch is an implementation detail.

Given that this is something that will evolve, change, and require specific solutions for when things grow, shouldn't we have a Search team?

One could argue that the team = the people tagged as "Specialist" for this feature / service on the team page. We've got experts but that just means they know a lot; not that they are responsible for it. Then again you're only supposed to be Specialist in one area. So if we pick the people who are experts, we have @vsizov @nick.thomas and @victorcete

mentioned in commit c11a7407

merged

Merged! @pcarranza please describe on team call.

@ernstvn done already (the team call)