Add gRPC messages to get the local branches of a repository

mentioned in issue gitaly#127 (closed)

added 1 commit

• 696fdb80 - Add gRPC messages to get the local branches of a repository

Compare with previous version

assigned to @jacobvosmaer-gitlab

@jacobvosmaer-gitlab I don't understand the build failure. Also, in https://gitlab.com/gitlab-org/gitaly/issues/134 you mentioned your preference for plain messages, but for commit and author I think the abstraction is worth it for cleanness.

unmarked as a Work In Progress

@eReGeBe you need Go 1.8. https://gitlab.com/gitlab-org/gitaly-proto/blob/master/README.md#contributing . Or rather, you need the same Go as gitaly-proto CI. Which is Go 1.8 now.

It's silly but I don't see a way to fix it.

@eReGeBe I wonder what we should do when name <email> fails to parse. How does this Git handle this itself?

I see how one gets to the 'author has a date' thing reading https://git-scm.com/docs/git-log#_pretty_formats where it lists:

           o   %an: author name

           o   %aN: author name (respecting .mailmap, see git-shortlog(1) or
               git-blame(1))

           o   %ae: author email

           o   %aE: author email (respecting .mailmap, see git-shortlog(1) or
               git-blame(1))

           o   %ad: author date (format respects --date= option)

           o   %aD: author date, RFC2822 style

etc.

assigned to @eReGeBe

@jacobvosmaer-gitlab yes, that's where I got the date concept from. It's weird, but it seems to be git's notation.

I don't see when name <email> would fail to parse. If I'm getting that data from an already existing git commit, can't I assume it's valid?

assigned to @jacobvosmaer-gitlab

added 1 commit

• 23f66005 - Add gRPC messages to get the local branches of a repository

Compare with previous version

added 1 commit

• 062ebc11 - Add gRPC messages to get the local branches of a repository

Compare with previous version

added 1 commit

• 36b79a27 - Add gRPC messages to get the local branches of a repository

Compare with previous version

marked as a Work In Progress

Remarked as WIP because I'm missing a param for sorting :)

added 1 commit

• be339b98 - Add gRPC messages to get the local branches of a repository

Compare with previous version

unmarked as a Work In Progress

@jacobvosmaer-gitlab ok, now it's ready for a review :) (I also went ahead of myself and made the server implementation. It's still WIP, but you can give it a look for how the message structure affects the code https://gitlab.com/gitlab-org/gitaly/merge_requests/103)

I had to go back to https://gitlab.com/gitlab-org/gitaly/issues/127 and look at the other MR's too to get a better understanding of this. :)

So this is defining a new batch operation that both fetches 'local' (non-remote) branches and metadata of their head commits. (Not a question, more talking out loud to see if I get it.)

@eReGeBe I think I agree with the structure but I have some questions about the scalar types. :)

assigned to @eReGeBe

added 1 commit

• 0580896d - Add gRPC messages to get the local branches of a repository

Compare with previous version

added 1 commit

• fcd00106 - Add gRPC messages to get the local branches of a repository

Compare with previous version

MR updated. Some discussions unresolved.

assigned to @jacobvosmaer-gitlab

resolved all discussions

mentioned in commit d418f1d0

merged

resolved all discussions

mentioned in issue gitaly#128 (closed)

mentioned in issue gitaly#217