gitaly-proto: add 'shard' and 'relative_path' string fields to Repository

Currently Repository only has a 'path' field that we fill with an absolute disk path.

Repository.new(path: '/home/git/repositories/foo/bar.git')

In the future we want to use it like this:

Repository.new(shard: 'storage01', relative_path: 'foo/bar.git')

• double-check what characters are allowed in storage shard names
• pick string or bytes for the shard field on the Repository proto

The work to make use of these fields is spread out over other issues.

mentioned in issue #146 (closed)

mentioned in issue #148 (closed)

I'm starting to think it is a bad idea to reuse path. Maybe the new situation should be:

Repository.new(shard: 'storage01', relative_path: 'foo/bar.git')

Edit: I have updated the description. The old proposal in the description was: Repository.new(shard: 'storage01', path: 'foo/bar.git').

changed title from gitaly-proto: add 'shard' string field to Repository to gitaly-proto: add 'shard' and 'relative_path' string fields to Repository

double-check what characters are allowed in storage shard names

From what I can see in GitLab-Rails, there isn't any validation on characters (I may be wrong though).

If there isn't, we should pick something, eg:

/^\w{1,20}$/

pick string or bytes for the shard field on the Repository proto

If we can, string is going to be better than bytes, considering we'll be using this in hashmaps a lot which will require equality checks, etc.

@andrewn hashmap usage is an internal detail. Inside gitaly, we can use string for whatever we want. But in the protobuf messages, string implies UTF-8.

assigned to @ahmadsherif

mentioned in merge request gitaly-proto!13 (merged)

mentioned in commit gitaly-proto@46a3e370

closed via commit gitaly-proto@46a3e370