Skip to content
Snippets Groups Projects

Update Django.gitlab-ci.yml

Merged username-removed-457882 requested to merge kennydude/gitlab-ci-yml:patch-1 into master
All threads resolved!

What does this MR do?

This updates the Django CI config so it's easier for others in the future to get tests passing.

It also removes the redundant migrate, as Django will create a test database automatically and run all migrations on it. This functionality works this way in case you need to ever run all your migrations from scratch again (i.e server dies).

Are there points in the code the reviewer needs to double check?

I don't know how to do it, but creating a file in the pre-test steps with the DATABASES config would make this template more plug-n-play.

Why was this MR needed?

Migrate wasn't needed and it isn't clear otherwise how to get tests working

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Zeger-Jan van de Weg
  • Zeger-Jan van de Weg resolved all discussions

    resolved all discussions

  • Thanks for your contributions! 💯

  • mentioned in commit 94fcb77e

  • No problem :) Maybe adding extra files to do with CI templates is something that can be added to Gitlab in the future?

  • Please register or sign in to reply
    Loading