Error during GDK install on Mac OS Sierra
Overview
I am trying to install the GDK as a way to start contributing back to the community, following the install instructions here:
https://about.gitlab.com/2016/06/08/getting-started-with-gitlab-development-kit/.
Problem
Overview
It appears that the required version of json, 1.8.3, is incompatible with ruby 2.4. Supporting proof is listed later.
Entered Command
make gitlab_repo=git@gitlab.com:dskinne12/gitlab-ce.git
Expected result
A full functional gitlab development kit install, with no red text error outputs.
Actual results
An error occurred while installing json (1.8.3), and Bundler cannot continue.
Make sure that `gem install json -v '1.8.3'` succeeds before bundling.```
### Possible Fix
If I manually edit the Gemfile in the gitlab directory to include
```gem 'json', '1.8.6'```
Then everything works correctly, until I run ```make update``` which overwrites the Gemfile. I was using 1.8.6 as that is the closest semantic version that I had installed on my machine.
### Supporting Evidence
1. https://github.com/flori/json/issues/303
2. https://github.com/rails/rails/issues/27450
It also appears that the reason that 1.8.3 is requested is that Ruby On Rails requires json 1.8.*, which theoretically means that 1.8.6 or another minor revision should be perfectly fine. I can provide any other info necessary.