Yarn executable not found / Build Failed #14497882

https://gitlab.com/gitlab-org/gitlab-development-kit/builds/14497882

/cc @mikegreiling

Is yarn not available in the GDK build image? If so how did the pipeline pass before this?

This is a very good question @mikegreiling. I see no yarn mentions in https://gitlab.com/gitlab-org/gitlab-development-kit/builds/14318138/raw, which was meant to test the merge request we are referring to

Anyway, let's add to the GDK build image.

we can probably copy/paste the command we use to install it in our omnibus build images: https://gitlab.com/gitlab-org/gitlab-omnibus-builder/merge_requests/30/diffs

@grzesiek can you take this? Otherwise I can take this issue when I return from paternity leave.

I will take it @mikegreiling!

assigned to @grzesiek

Is yarn in the 'prepare' docs?

To answer my own question: yet it is. Good :)

mentioned in merge request !293 (merged)

@mikegreiling I added yarn to the docker image, now getting this error:

cd /home/gdk/gitlab-development-kit/gitlab && yarn install --pure-lockfile
yarn install v0.23.2
[1/4] Resolving packages...
[2/4] Fetching packages...
error webpack@2.3.3: The engine "node" is incompatible with this module. Expected version ">=4.3.0 <5.0.0 || >=5.10".
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.
error Found incompatible module
make: *** [.gitlab-yarn] Error 1
Makefile:55: recipe for target '.gitlab-yarn' failed

Does it look legitimate?

I've seen that error before in my development environment. You have to upgrade NodeJS to a supported version.

I don't know which version of node we have installed in our GDK build image, but if it is < 4.3.0 it should be upgraded.

You could alternately get by specifying the --ignore-engines flag in yarn since we aren't really testing here whether we can compile webpack assets, rather we're just testing whether the GDK does its thing.

Thanks @stanhu @mikegreiling. In ubuntu xenial we have nodejs in version 4.2.6~dfsg-1ubuntu4. Does it mean that because of using yarn we no longer can use nodejs from packages? It might require changes in GDK's docs.

It's not because of yarn, it's because of webpack, so this dependency requirement has already been in place for a while. yarn merely enforces this dependency by default whenever it is run whereas npm did not.

Thanks for explanation @mikegreiling. Makes sense. I will fix Dockerfile and CI in GDK, and create an issue about improving our docs, since documentation needs to be updated in that case.

@grzesiek Yes, on Ubuntu, I've had to upgrade NodeJS by taking an external apt repository: https://nodejs.org/en/download/package-manager/#debian-and-ubuntu-based-linux-distributions

@stanhu Yes, let's do the same in Dockerfile https://gitlab.com/gitlab-org/gitlab-development-kit/commit/4e3e1acc2806d408181b397ed8f3aeb1ef161a6d!

closed via merge request !293 (merged)

mentioned in issue #227