Skip to content
Snippets Groups Projects

WIP: Initial take on Review Apps

Open WIP: Initial take on Review Apps
gitlab-review-apps into master
Open Kamil Trzcińśki requested to merge gitlab-review-apps into master

This is initial changes to build review apps based on GDK:

  1. It creates an extended Docker image that is prebuilt: it has all components, it has initial dependencies installed, it has preseeded database,
  2. It extends Makefile to allow checking out arbitrary SHA for the gitlab repository.

Currently, the image is manually built and pushed to my docker hub repo. It's to make it easier, now, for testing.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Kamil Trzcińśki
    Kamil Trzcińśki @ayufan ·
    Author Maintainer

    It currently uses gitlab-ce-review-apps on gitlab-internal GKE.

  • Mark Pundsack
    Mark Pundsack @markpundsack ·
    Developer

    Should the review app stuff be in a separate Dockerfile? This implies you'll always be running review apps, even when doing local development. (I guess local development just doesn't use Docker, so maybe it's a non-issue, but that's the normal thing to do.)

Please register or sign in to reply