Move gitlab-shell to make Go development easier

For Go development we want to have a GOPATH directory layout for gitlab-shell.

Because this is confusing and distracting for Ruby developers, this change puts the GOPATH at /go-gitlab-shell, and makes /gitlab-shell a symlink to the real directory where the gitlab-shell repository is.

Discussion about Go in gitlab-shell: https://gitlab.com/gitlab-org/gitlab-shell/issues/80

Gitlab-shell Go merge request: https://gitlab.com/gitlab-org/gitlab-shell/merge_requests/127

mentioned in merge request gitlab-shell!127 (merged)

added 1 commit

• 63a91a7f - Install gitlab-shell with symlink and Go

Compare with previous version

unmarked as a Work In Progress

changed title from WIP First version of script to create gitlab-shell symlink to Move gitlab-shell to make Go development easier

assigned to @grzesiek

mentioned in issue gitaly#186 (closed)

@jacobvosmaer-gitlab Can you elaborate why

Because this is confusing and distracting for Ruby developers, this change puts the GOPATH at /go-gitlab-shell, and makes /gitlab-shell a symlink to the real directory where the gitlab-shell repository is.

Would it make sense to maintain a single source of truth here as well?

The source of truth would be /go-gitlab-shell/src/gitlab.com/gitlab-org/gitlab-shell. The symlink is only for convenience.

/gitlab-shell -> /go-gitlab-shell/src/gitlab.com/gitlab-org/gitlab-shell

I agree it would be simpler, at least for GDK maintainers, if there was no symlink. But it feels wrong to me to impose the inconvenience of GOPATH nesting on gitlab-shell contributors when it is mostly written in Ruby.

assigned to @jacobvosmaer-gitlab

assigned to @grzesiek

@jacobvosmaer-gitlab Okay, let's merge it then!

merged

mentioned in commit 6999b638