Skip to content
Snippets Groups Projects
Select Git revision
  • ag-test
  • rs-test
  • master default protected
  • test-me-pa
  • mksionek-master-patch-52381
  • new-branch-10
  • test-conflicts
  • test-suggestions
  • alejandro-test
  • patch-25
  • winh-test-image-doscussion
  • stg-lfs-image-test-2
  • stg-lfs-image-test
  • test42016
  • issue_42016
  • issue-32709
  • add-codeowners
  • ClemMakesApps-master-patch-62759
  • bvl-staging-test
  • bvl-merge-base-api
  • v9.2.0-rc6 protected
  • v9.2.0-rc5 protected
  • v9.2.0-rc4 protected
  • v9.2.0-rc3 protected
  • v9.1.4 protected
  • v9.2.0-rc2 protected
  • v9.2.0-rc1 protected
  • v9.1.3 protected
  • v8.17.6 protected
  • v9.0.7 protected
  • v9.1.2 protected
  • v9.1.1 protected
  • v9.2.0.pre protected
  • v9.1.0 protected
  • v9.1.0-rc7 protected
  • v9.1.0-rc6 protected
  • v9.0.6 protected
  • v9.1.0-rc5 protected
  • v9.1.0-rc4 protected
  • v9.1.0-rc3 protected
40 results

broadcast_messages.rb

  • joshbabier's avatar
    a92281ce
    TST: Use more accurate time windows so tests do not fail · a92281ce
    joshbabier authored
    Currently, the way the 'starts_at' and 'ends_at' attributes are set,
    if the specs are run at one second to midnight, the broadcast message
    will expire in one second. I have changed it so that we are guaranteed
    a period of one day until expiration. I believe this is the desired
    behaviour and it's also consistent with the rest of the factory.
    
    This corrects the following three specs that can fail depending upon
    where and when they are run:
    
    ./spec/helpers/broadcast_messages_helper_spec.rb:42
    ./spec/models/broadcast_message_spec.rb:26
    ./spec/models/broadcast_message_spec.rb:47
    a92281ce
    History
    TST: Use more accurate time windows so tests do not fail
    joshbabier authored
    Currently, the way the 'starts_at' and 'ends_at' attributes are set,
    if the specs are run at one second to midnight, the broadcast message
    will expire in one second. I have changed it so that we are guaranteed
    a period of one day until expiration. I believe this is the desired
    behaviour and it's also consistent with the rest of the factory.
    
    This corrects the following three specs that can fail depending upon
    where and when they are run:
    
    ./spec/helpers/broadcast_messages_helper_spec.rb:42
    ./spec/models/broadcast_message_spec.rb:26
    ./spec/models/broadcast_message_spec.rb:47
Code owners
Assign users and groups as approvers for specific file changes. Learn more.