Skip to content
Snippets Groups Projects
Select Git revision
  • ag-test
  • rs-test
  • master default protected
  • test-me-pa
  • mksionek-master-patch-52381
  • new-branch-10
  • test-conflicts
  • test-suggestions
  • alejandro-test
  • patch-25
  • winh-test-image-doscussion
  • stg-lfs-image-test-2
  • stg-lfs-image-test
  • test42016
  • issue_42016
  • issue-32709
  • add-codeowners
  • ClemMakesApps-master-patch-62759
  • bvl-staging-test
  • bvl-merge-base-api
  • v9.2.0-rc6 protected
  • v9.2.0-rc5 protected
  • v9.2.0-rc4 protected
  • v9.2.0-rc3 protected
  • v9.1.4 protected
  • v9.2.0-rc2 protected
  • v9.2.0-rc1 protected
  • v9.1.3 protected
  • v8.17.6 protected
  • v9.0.7 protected
  • v9.1.2 protected
  • v9.1.1 protected
  • v9.2.0.pre protected
  • v9.1.0 protected
  • v9.1.0-rc7 protected
  • v9.1.0-rc6 protected
  • v9.0.6 protected
  • v9.1.0-rc5 protected
  • v9.1.0-rc4 protected
  • v9.1.0-rc3 protected
40 results

extracts_path_spec.rb

Blame
    • Sean McGivern's avatar
      1022456b
      Allow browsing branches that end with '.atom' · 1022456b
      Sean McGivern authored
      We need to do two things to support this:
      
      1. Simplify the regex capture in the routing for the CommitsController
         to not exclude the '.atom' suffix. That's a perfectly valid git
         branch name, so we shouldn't blow up if we get it.
      2. Because Rails now can't automatically detect the request format, add
         some code to do so in `ExtractPath` when there is no path. This means
         that, given branches 'foo' and 'foo.atom', the Atom feed for the
         former is unroutable. To fix this: don't do that! Give the branches
         different names!
      1022456b
      History
      Allow browsing branches that end with '.atom'
      Sean McGivern authored
      We need to do two things to support this:
      
      1. Simplify the regex capture in the routing for the CommitsController
         to not exclude the '.atom' suffix. That's a perfectly valid git
         branch name, so we shouldn't blow up if we get it.
      2. Because Rails now can't automatically detect the request format, add
         some code to do so in `ExtractPath` when there is no path. This means
         that, given branches 'foo' and 'foo.atom', the Atom feed for the
         former is unroutable. To fix this: don't do that! Give the branches
         different names!
    Code owners
    Assign users and groups as approvers for specific file changes. Learn more.