Skip to content
Snippets Groups Projects
Select Git revision
  • ag-test
  • rs-test
  • master default protected
  • test-me-pa
  • mksionek-master-patch-52381
  • new-branch-10
  • test-conflicts
  • test-suggestions
  • alejandro-test
  • patch-25
  • winh-test-image-doscussion
  • stg-lfs-image-test-2
  • stg-lfs-image-test
  • test42016
  • issue_42016
  • issue-32709
  • add-codeowners
  • ClemMakesApps-master-patch-62759
  • bvl-staging-test
  • bvl-merge-base-api
  • v9.2.0-rc6 protected
  • v9.2.0-rc5 protected
  • v9.2.0-rc4 protected
  • v9.2.0-rc3 protected
  • v9.1.4 protected
  • v9.2.0-rc2 protected
  • v9.2.0-rc1 protected
  • v9.1.3 protected
  • v8.17.6 protected
  • v9.0.7 protected
  • v9.1.2 protected
  • v9.1.1 protected
  • v9.2.0.pre protected
  • v9.1.0 protected
  • v9.1.0-rc7 protected
  • v9.1.0-rc6 protected
  • v9.0.6 protected
  • v9.1.0-rc5 protected
  • v9.1.0-rc4 protected
  • v9.1.0-rc3 protected
40 results

issue_spec.rb

  • Timothy Andrew's avatar
    5d88de09
    Refactor `Issue#related_branches` · 5d88de09
    Timothy Andrew authored
    - Previously, the controller held the logic to calculate
      related branches, which was:
    
      `<branches ending with `issue.iid`> - <branches with a merge request referenced in the current issue>`
    
    - This logic belongs in the `related_branches` method, not in the
      controller. This commit makes this change.
    
    - This means that `Issue#related_branches` now needs to take a `User`.
      When we find the branches that have a merge request referenced in the
      current issue, this is limited to merge requests that the current user
      has access to.
    
    - This is not directly related to #14566, but is a related refactoring.
    5d88de09
    History
    Refactor `Issue#related_branches`
    Timothy Andrew authored
    - Previously, the controller held the logic to calculate
      related branches, which was:
    
      `<branches ending with `issue.iid`> - <branches with a merge request referenced in the current issue>`
    
    - This logic belongs in the `related_branches` method, not in the
      controller. This commit makes this change.
    
    - This means that `Issue#related_branches` now needs to take a `User`.
      When we find the branches that have a merge request referenced in the
      current issue, this is limited to merge requests that the current user
      has access to.
    
    - This is not directly related to #14566, but is a related refactoring.
Code owners
Assign users and groups as approvers for specific file changes. Learn more.