Skip to content
Snippets Groups Projects
Select Git revision
  • ag-test
  • rs-test
  • master default protected
  • test-me-pa
  • mksionek-master-patch-52381
  • new-branch-10
  • test-conflicts
  • test-suggestions
  • alejandro-test
  • patch-25
  • winh-test-image-doscussion
  • stg-lfs-image-test-2
  • stg-lfs-image-test
  • test42016
  • issue_42016
  • issue-32709
  • add-codeowners
  • ClemMakesApps-master-patch-62759
  • bvl-staging-test
  • bvl-merge-base-api
  • v9.2.0-rc6 protected
  • v9.2.0-rc5 protected
  • v9.2.0-rc4 protected
  • v9.2.0-rc3 protected
  • v9.1.4 protected
  • v9.2.0-rc2 protected
  • v9.2.0-rc1 protected
  • v9.1.3 protected
  • v8.17.6 protected
  • v9.0.7 protected
  • v9.1.2 protected
  • v9.1.1 protected
  • v9.2.0.pre protected
  • v9.1.0 protected
  • v9.1.0-rc7 protected
  • v9.1.0-rc6 protected
  • v9.0.6 protected
  • v9.1.0-rc5 protected
  • v9.1.0-rc4 protected
  • v9.1.0-rc3 protected
40 results

receiver.rb

  • Lin Jen-Shin's avatar
    6cfd0282
    Implement #3243 New Issue by email · 6cfd0282
    Lin Jen-Shin authored
    So we extend Gitlab::Email::Receiver for this new behaviour,
    however we might want to split it into another class for better
    testing it.
    
    Another issue is that, currently it's using this to parse project
    identifier:
    
        Gitlab::IncomingEmail.key_from_address
    
    Which is using:
    
        Gitlab.config.incoming_email.address
    
    for the receiver name. This is probably `reply` because it's used
    for replying to a specific issue. We might want to introduce another
    config for this, or just use `reply` instead of `incoming`.
    
    I'll prefer to introduce a new config for this, or just change
    `reply` to `incoming` because it would make sense for replying to
    there, too.
    
    The email template used in tests were copied and modified from:
    `emails/valid_reply.eml` which I hope is ok.
    6cfd0282
    History
    Implement #3243 New Issue by email
    Lin Jen-Shin authored
    So we extend Gitlab::Email::Receiver for this new behaviour,
    however we might want to split it into another class for better
    testing it.
    
    Another issue is that, currently it's using this to parse project
    identifier:
    
        Gitlab::IncomingEmail.key_from_address
    
    Which is using:
    
        Gitlab.config.incoming_email.address
    
    for the receiver name. This is probably `reply` because it's used
    for replying to a specific issue. We might want to introduce another
    config for this, or just use `reply` instead of `incoming`.
    
    I'll prefer to introduce a new config for this, or just change
    `reply` to `incoming` because it would make sense for replying to
    there, too.
    
    The email template used in tests were copied and modified from:
    `emails/valid_reply.eml` which I hope is ok.
Code owners
Assign users and groups as approvers for specific file changes. Learn more.