Skip to content
Snippets Groups Projects
Select Git revision
  • ag-test
  • rs-test
  • master default protected
  • test-me-pa
  • mksionek-master-patch-52381
  • new-branch-10
  • test-conflicts
  • test-suggestions
  • alejandro-test
  • patch-25
  • winh-test-image-doscussion
  • stg-lfs-image-test-2
  • stg-lfs-image-test
  • test42016
  • issue_42016
  • issue-32709
  • add-codeowners
  • ClemMakesApps-master-patch-62759
  • bvl-staging-test
  • bvl-merge-base-api
  • v9.2.0-rc6 protected
  • v9.2.0-rc5 protected
  • v9.2.0-rc4 protected
  • v9.2.0-rc3 protected
  • v9.1.4 protected
  • v9.2.0-rc2 protected
  • v9.2.0-rc1 protected
  • v9.1.3 protected
  • v8.17.6 protected
  • v9.0.7 protected
  • v9.1.2 protected
  • v9.1.1 protected
  • v9.2.0.pre protected
  • v9.1.0 protected
  • v9.1.0-rc7 protected
  • v9.1.0-rc6 protected
  • v9.0.6 protected
  • v9.1.0-rc5 protected
  • v9.1.0-rc4 protected
  • v9.1.0-rc3 protected
40 results

base_service.rb

Blame
    • Kamil Trzcinski's avatar
      a431ca0f
      Don't execute git hooks if you create branch as part of other change · a431ca0f
      Kamil Trzcinski authored
      Currently, our procedure for adding a commit requires us to execute `CreateBranchService` before file creation.
      It's OK, but also we do execute `git hooks` (the `PostReceive` sidekiq job) as part of this process.
      However, this hook is execute before the file is actually committed, so the ref is updated.
      
      Secondly, we do execute a `git hooks` after committing file and updating ref.
      This results in duplicate `PostReceive` jobs, where the first one is completely invalid.
      
      This change makes the branch creation, something that is intermediate step of bigger process (file creation or update, commit cherry pick or revert) to not execute git hooks.
      a431ca0f
      History
      Don't execute git hooks if you create branch as part of other change
      Kamil Trzcinski authored
      Currently, our procedure for adding a commit requires us to execute `CreateBranchService` before file creation.
      It's OK, but also we do execute `git hooks` (the `PostReceive` sidekiq job) as part of this process.
      However, this hook is execute before the file is actually committed, so the ref is updated.
      
      Secondly, we do execute a `git hooks` after committing file and updating ref.
      This results in duplicate `PostReceive` jobs, where the first one is completely invalid.
      
      This change makes the branch creation, something that is intermediate step of bigger process (file creation or update, commit cherry pick or revert) to not execute git hooks.
    Code owners
    Assign users and groups as approvers for specific file changes. Learn more.