Skip to content
Snippets Groups Projects
Select Git revision
  • ag-test
  • rs-test
  • master default protected
  • test-me-pa
  • mksionek-master-patch-52381
  • new-branch-10
  • test-conflicts
  • test-suggestions
  • alejandro-test
  • patch-25
  • winh-test-image-doscussion
  • stg-lfs-image-test-2
  • stg-lfs-image-test
  • test42016
  • issue_42016
  • issue-32709
  • add-codeowners
  • ClemMakesApps-master-patch-62759
  • bvl-staging-test
  • bvl-merge-base-api
  • v9.2.0-rc6 protected
  • v9.2.0-rc5 protected
  • v9.2.0-rc4 protected
  • v9.2.0-rc3 protected
  • v9.1.4 protected
  • v9.2.0-rc2 protected
  • v9.2.0-rc1 protected
  • v9.1.3 protected
  • v8.17.6 protected
  • v9.0.7 protected
  • v9.1.2 protected
  • v9.1.1 protected
  • v9.2.0.pre protected
  • v9.1.0 protected
  • v9.1.0-rc7 protected
  • v9.1.0-rc6 protected
  • v9.0.6 protected
  • v9.1.0-rc5 protected
  • v9.1.0-rc4 protected
  • v9.1.0-rc3 protected
40 results

git_access.rb

  • Stan Hu's avatar
    4be77d0b
    Improve multiple branch push performance by memoizing permission checking · 4be77d0b
    Stan Hu authored
    If you attempt to push thousands of branches at once, the 60-second timeout
    will occur because GitAccess checking does a lot of work to check if the
    user has permission to push to a branch. This changes does two things:
    
    1. Instead of making 1 DB query per branch push, use a memoized list of protected branches to check
    2. Memoize what permissions the user has to perform on this project
    
    On a test of 10,000 branch pushes, this prevents gitlab-shell from hitting the 60-second
    timeout.
    
    Closes #17225
    4be77d0b
    History
    Improve multiple branch push performance by memoizing permission checking
    Stan Hu authored
    If you attempt to push thousands of branches at once, the 60-second timeout
    will occur because GitAccess checking does a lot of work to check if the
    user has permission to push to a branch. This changes does two things:
    
    1. Instead of making 1 DB query per branch push, use a memoized list of protected branches to check
    2. Memoize what permissions the user has to perform on this project
    
    On a test of 10,000 branch pushes, this prevents gitlab-shell from hitting the 60-second
    timeout.
    
    Closes #17225
Code owners
Assign users and groups as approvers for specific file changes. Learn more.