-
- Downloads
There was a problem fetching the pipeline summary.
Use bcc for pipeline emails because:
We use bcc here because we don't want to generate this emails for a thousand times. This could be potentially expensive in a loop, and recipients would contain all project watchers so it could be a lot.
parent
12ef494d
No related branches found
No related tags found
Pipeline #
Showing
- app/mailers/emails/pipelines.rb 11 additions, 6 deletionsapp/mailers/emails/pipelines.rb
- app/services/notification_service.rb 1 addition, 3 deletionsapp/services/notification_service.rb
- spec/models/ci/pipeline_spec.rb 1 addition, 1 deletionspec/models/ci/pipeline_spec.rb
- spec/support/email_helpers.rb 4 additions, 4 deletionsspec/support/email_helpers.rb
- spec/workers/pipeline_notification_worker_spec.rb 6 additions, 8 deletionsspec/workers/pipeline_notification_worker_spec.rb
Loading
-
Just flagging the issue that sending mail through BCC only is causing issues with spamassassin. When recieving CI notifications, spamassassin gives them a high score with it's REPLYTO_WITHOUT_TO_CC flag. Would it be good to provide either a means to drop the REPLYTO header, or allow the old TO addressing as an override?
-
@skotos Please post your concern at #24749 (moved), thanks!
Please register or sign in to comment