Skip to content
Snippets Groups Projects
Commit 0671db52 authored by Lin Jen-Shin's avatar Lin Jen-Shin
Browse files
parent c491f669
No related branches found
No related tags found
1 merge request!3363Implement #3243 New Issue by email
Loading
Loading
@@ -43,17 +43,16 @@ module Gitlab
end.join
end
 
def verify_record!(record, exception, name)
def verify_record!(record:, invalid_exception:, record_name:)
return if record.persisted?
 
error_title =
"The #{name} could not be created for the following reasons:"
error_title = "The #{record_name} could not be created for the following reasons:"
 
msg = error_title + record.errors.full_messages.map do |error|
"\n\n- #{error}"
end.join
 
raise exception, msg
raise invalid_exception, msg
end
end
end
Loading
Loading
Loading
Loading
@@ -22,7 +22,10 @@ module Gitlab
 
validate_permission!(:create_issue)
 
verify_record!(create_issue, InvalidIssueError, 'issue')
verify_record!(
record: create_issue,
invalid_exception: InvalidIssueError,
record_name: 'issue')
end
 
def author
Loading
Loading
Loading
Loading
@@ -19,7 +19,10 @@ module Gitlab
raise NoteableNotFoundError unless sent_notification.noteable
raise EmptyEmailError if message.blank?
 
verify_record!(create_note, InvalidNoteError, 'comment')
verify_record!(
record: create_note,
invalid_exception: InvalidNoteError,
record_name: 'comment')
end
 
def author
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment