-
- Downloads
There was a problem fetching the pipeline summary.
Merge branch '24281-issue-merge-request-sidebar-subscribe-button-style-improvement' into 'master'
Remove the help text under the sidebar subscribe button and style it inline ## What does this MR do? Remove the help text under the sidebar subscribe button and style it inline ## Are there points in the code the reviewer needs to double check? ## Why was this MR needed? Current help text is over obvious and pushes references too far down. Also the subscribe button is now consistently styled and not a complete block button anymore. approved by @awhildy ## Screenshots (if relevant) before:  after:  ## Does this MR meet the acceptance criteria? - [x] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added - [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md) - [ ] API support added - Tests - [ ] Added for this feature/bug - [x] All builds are passing - [x] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html) - [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides) - [x] Branch has no merge conflicts with `master` (if it does - rebase it please) - [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits) ## What are the relevant issue numbers? Closes #24281 See merge request !7389
No related branches found
No related tags found
Pipeline #
Showing
- app/assets/javascripts/boards/components/board_sidebar.js.es6 1 addition, 1 deletion...assets/javascripts/boards/components/board_sidebar.js.es6
- app/assets/javascripts/subscription.js 0 additions, 52 deletionsapp/assets/javascripts/subscription.js
- app/assets/javascripts/subscription.js.es6 50 additions, 0 deletionsapp/assets/javascripts/subscription.js.es6
- app/assets/stylesheets/pages/boards.scss 0 additions, 1 deletionapp/assets/stylesheets/pages/boards.scss
- app/views/projects/boards/components/sidebar/_notifications.html.haml 4 additions, 8 deletions...ojects/boards/components/sidebar/_notifications.html.haml
- app/views/shared/issuable/_sidebar.html.haml 3 additions, 8 deletionsapp/views/shared/issuable/_sidebar.html.haml
- changelogs/unreleased/24281-issue-merge-request-sidebar-subscribe-button-style-improvement.yml 4 additions, 0 deletions...ge-request-sidebar-subscribe-button-style-improvement.yml
- spec/features/boards/sidebar_spec.rb 2 additions, 2 deletionsspec/features/boards/sidebar_spec.rb
Loading
Please register or sign in to comment