-
- Downloads
There was a problem fetching the pipeline summary.
Merge branch '23500-enable-colorvariable' into 'master'
Enable ColorVariable in scss-lint ## What does this MR do? - Enable the ColorVariable rule in`.scss-lint.yml` - Change all color literals in `app/assets/stylesheets` to color variables ## Why was this MR needed? - Enforce the usage of color variables to better constrain the various color values being used ## Does this MR meet the acceptance criteria? - [x] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added - [x] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md) - Tests - [x] All builds are passing - [x] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html) - [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides) - [x] Branch has no merge conflicts with `master` (if it does - rebase it please) - [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits) ## What are the relevant issue numbers? Closes #23500 See merge request !7319
No related branches found
No related tags found
Pipeline #
Showing
- .scss-lint.yml 1 addition, 1 deletion.scss-lint.yml
- app/assets/stylesheets/framework/avatar.scss 1 addition, 1 deletionapp/assets/stylesheets/framework/avatar.scss
- app/assets/stylesheets/framework/blocks.scss 2 additions, 2 deletionsapp/assets/stylesheets/framework/blocks.scss
- app/assets/stylesheets/framework/buttons.scss 11 additions, 11 deletionsapp/assets/stylesheets/framework/buttons.scss
- app/assets/stylesheets/framework/calendar.scss 2 additions, 2 deletionsapp/assets/stylesheets/framework/calendar.scss
- app/assets/stylesheets/framework/callout.scss 12 additions, 12 deletionsapp/assets/stylesheets/framework/callout.scss
- app/assets/stylesheets/framework/common.scss 31 additions, 31 deletionsapp/assets/stylesheets/framework/common.scss
- app/assets/stylesheets/framework/dropdowns.scss 2 additions, 2 deletionsapp/assets/stylesheets/framework/dropdowns.scss
- app/assets/stylesheets/framework/files.scss 10 additions, 10 deletionsapp/assets/stylesheets/framework/files.scss
- app/assets/stylesheets/framework/forms.scss 6 additions, 6 deletionsapp/assets/stylesheets/framework/forms.scss
- app/assets/stylesheets/framework/gitlab-theme.scss 26 additions, 6 deletionsapp/assets/stylesheets/framework/gitlab-theme.scss
- app/assets/stylesheets/framework/header.scss 2 additions, 2 deletionsapp/assets/stylesheets/framework/header.scss
- app/assets/stylesheets/framework/issue_box.scss 3 additions, 3 deletionsapp/assets/stylesheets/framework/issue_box.scss
- app/assets/stylesheets/framework/jquery.scss 8 additions, 8 deletionsapp/assets/stylesheets/framework/jquery.scss
- app/assets/stylesheets/framework/layout.scss 1 addition, 1 deletionapp/assets/stylesheets/framework/layout.scss
- app/assets/stylesheets/framework/lists.scss 6 additions, 6 deletionsapp/assets/stylesheets/framework/lists.scss
- app/assets/stylesheets/framework/markdown_area.scss 5 additions, 5 deletionsapp/assets/stylesheets/framework/markdown_area.scss
- app/assets/stylesheets/framework/mixins.scss 3 additions, 3 deletionsapp/assets/stylesheets/framework/mixins.scss
- app/assets/stylesheets/framework/mobile.scss 3 additions, 3 deletionsapp/assets/stylesheets/framework/mobile.scss
- app/assets/stylesheets/framework/nav.scss 1 addition, 1 deletionapp/assets/stylesheets/framework/nav.scss
Loading
Please register or sign in to comment