Skip to content
Snippets Groups Projects
Verified Commit 437d4c76 authored by Dmitriy Zaporozhets's avatar Dmitriy Zaporozhets
Browse files

Remove duplication in diff_helper.rb

parent 5f239093
No related branches found
No related tags found
1 merge request!1812Remove code duplication
Loading
@@ -132,25 +132,11 @@ module DiffHelper
Loading
@@ -132,25 +132,11 @@ module DiffHelper
end end
   
def inline_diff_btn def inline_diff_btn
params_copy = params.dup diff_btn('Inline', 'inline', params[:view] != 'parallel')
params_copy[:view] = 'inline'
# Always use HTML to handle case where JSON diff rendered this button
params_copy.delete(:format)
link_to url_for(params_copy), id: "inline-diff-btn", class: (params[:view] != 'parallel' ? 'btn active' : 'btn') do
'Inline'
end
end end
   
def parallel_diff_btn def parallel_diff_btn
params_copy = params.dup diff_btn('Side-by-side', 'parallel', params[:view] == 'parallel')
params_copy[:view] = 'parallel'
# Always use HTML to handle case where JSON diff rendered this button
params_copy.delete(:format)
link_to url_for(params_copy), id: "parallel-diff-btn", class: (params[:view] == 'parallel' ? 'btn active' : 'btn') do
'Side-by-side'
end
end end
   
def submodule_link(blob, ref, repository = @repository) def submodule_link(blob, ref, repository = @repository)
Loading
@@ -187,4 +173,18 @@ module DiffHelper
Loading
@@ -187,4 +173,18 @@ module DiffHelper
def editable_diff?(diff) def editable_diff?(diff)
!diff.deleted_file && @merge_request && @merge_request.source_project !diff.deleted_file && @merge_request && @merge_request.source_project
end end
private
def diff_btn(title, name, selected)
params_copy = params.dup
params_copy[:view] = name
# Always use HTML to handle case where JSON diff rendered this button
params_copy.delete(:format)
link_to url_for(params_copy), id: "#{name}-diff-btn", class: (selected ? 'btn active' : 'btn') do
title
end
end
end end
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment