-
- Downloads
There was a problem fetching the pipeline summary.
Merge branch 'new-issue-by-email' into 'master'
Implement #3243 New Issue by email So we extend Gitlab::Email::Receiver for this new behaviour, however we might want to split it into another class for better testing it. Another issue is that, currently it's using this to parse project identifier: Gitlab::IncomingEmail.key_from_address Which is using: Gitlab.config.incoming_email.address for the receiver name. This is probably `reply` because it's used for replying to a specific issue. We might want to introduce another config for this, or just use `reply` instead of `incoming`. I'll prefer to introduce a new config for this, or just change `reply` to `incoming` because it would make sense for replying to there, too. The email template used in tests were copied and modified from: `emails/valid_reply.eml` which I hope is ok. /cc @DouweM #3243 See merge request !3363
Showing
- CHANGELOG 1 addition, 0 deletionsCHANGELOG
- app/assets/stylesheets/pages/issues.scss 30 additions, 0 deletionsapp/assets/stylesheets/pages/issues.scss
- app/models/ci/build.rb 1 addition, 1 deletionapp/models/ci/build.rb
- app/models/project.rb 7 additions, 0 deletionsapp/models/project.rb
- app/views/projects/issues/_issue_by_email.html.haml 27 additions, 0 deletionsapp/views/projects/issues/_issue_by_email.html.haml
- app/views/projects/issues/index.html.haml 6 additions, 1 deletionapp/views/projects/issues/index.html.haml
- app/workers/email_receiver_worker.rb 29 additions, 25 deletionsapp/workers/email_receiver_worker.rb
- lib/gitlab/email/handler.rb 17 additions, 0 deletionslib/gitlab/email/handler.rb
- lib/gitlab/email/handler/base_handler.rb 60 additions, 0 deletionslib/gitlab/email/handler/base_handler.rb
- lib/gitlab/email/handler/create_issue_handler.rb 52 additions, 0 deletionslib/gitlab/email/handler/create_issue_handler.rb
- lib/gitlab/email/handler/create_note_handler.rb 55 additions, 0 deletionslib/gitlab/email/handler/create_note_handler.rb
- lib/gitlab/email/receiver.rb 35 additions, 82 deletionslib/gitlab/email/receiver.rb
- lib/gitlab/incoming_email.rb 3 additions, 3 deletionslib/gitlab/incoming_email.rb
- spec/features/issues_spec.rb 29 additions, 0 deletionsspec/features/issues_spec.rb
- spec/fixtures/emails/valid_new_issue.eml 23 additions, 0 deletionsspec/fixtures/emails/valid_new_issue.eml
- spec/fixtures/emails/valid_new_issue_empty.eml 18 additions, 0 deletionsspec/fixtures/emails/valid_new_issue_empty.eml
- spec/fixtures/emails/wrong_authentication_token.eml 18 additions, 0 deletionsspec/fixtures/emails/wrong_authentication_token.eml
- spec/fixtures/emails/wrong_mail_key.eml 0 additions, 0 deletionsspec/fixtures/emails/wrong_mail_key.eml
- spec/lib/gitlab/email/email_shared_blocks.rb 41 additions, 0 deletionsspec/lib/gitlab/email/email_shared_blocks.rb
- spec/lib/gitlab/email/handler/create_issue_handler_spec.rb 79 additions, 0 deletionsspec/lib/gitlab/email/handler/create_issue_handler_spec.rb
Loading
Please register or sign in to comment