Remove temporary stub method from ci config nodes

lib/gitlab/ci/config/node/configurable.rb

@@ -23,7 +23,7 @@ module Gitlab
             end
           end
-          def compose!(deps)
+          def compose!(deps = nil)
             return unless valid?
             self.class.nodes.each do |key, factory|

lib/gitlab/ci/config/node/entry.rb

@@ -20,12 +20,6 @@ module Gitlab
             @validator.validate(:new)
           end
-          # Temporary method
-          #
-          def process!(deps = nil)
-            compose!(deps)
-          end
-
           def compose!(deps = nil)
             return unless valid?

lib/gitlab/ci/config/node/job.rb

@@ -82,7 +82,7 @@ module Gitlab
                   :cache, :image, :services, :only, :except, :variables,
                   :artifacts
-          def compose!(deps)
+          def compose!(deps = nil)
             super do
               if type_defined? && !stage_defined?
                 @entries[:stage] = @entries[:type]

spec/lib/gitlab/ci/config/node/cache_spec.rb

@@ -4,7 +4,7 @@ describe Gitlab::Ci::Config::Node::Cache do
   let(:entry) { described_class.new(config) }
   describe 'validations' do
-    before { entry.process! }
+    before { entry.compose! }
     context 'when entry config value is correct' do
       let(:config) do

spec/lib/gitlab/ci/config/node/global_spec.rb

@@ -27,8 +27,8 @@ describe Gitlab::Ci::Config::Node::Global do
           spinach: { script: 'spinach' } }
       end
-      describe '#process!' do
-        before { global.process! }
+      describe '#compose!' do
+        before { global.compose! }
         it 'creates nodes hash' do
           expect(global.descendants).to be_an Array
@@ -59,7 +59,7 @@ describe Gitlab::Ci::Config::Node::Global do
         end
       end
-      context 'when not processed' do
+      context 'when not composed' do
         describe '#before_script' do
           it 'returns nil' do
             expect(global.before_script).to be nil
@@ -73,8 +73,8 @@ describe Gitlab::Ci::Config::Node::Global do
         end
       end
-      context 'when processed' do
-        before { global.process! }
+      context 'when composed' do
+        before { global.compose! }
         describe '#before_script' do
           it 'returns correct script' do
@@ -148,8 +148,11 @@ describe Gitlab::Ci::Config::Node::Global do
     end
     context 'when most of entires not defined' do
-      let(:hash) { { cache: { key: 'a' }, rspec: { script: %w[ls] } } }
-      before { global.process! }
+      before { global.compose! }
+
+      let(:hash) do
+        { cache: { key: 'a' }, rspec: { script: %w[ls] } }
+      end
       describe '#nodes' do
         it 'instantizes all nodes' do
@@ -188,8 +191,11 @@ describe Gitlab::Ci::Config::Node::Global do
     # details.
     #
     context 'when entires specified but not defined' do
-      let(:hash) { { variables: nil, rspec: { script: 'rspec' } } }
-      before { global.process! }
+      before { global.compose! }
+
+      let(:hash) do
+        { variables: nil, rspec: { script: 'rspec' } }
+      end
       describe '#variables' do
         it 'undefined entry returns a default value' do
@@ -200,7 +206,7 @@ describe Gitlab::Ci::Config::Node::Global do
   end
   context 'when hash is not valid' do
-    before { global.process! }
+    before { global.compose! }
     let(:hash) do
       { before_script: 'ls' }

spec/lib/gitlab/ci/config/node/job_spec.rb

@@ -3,7 +3,7 @@ require 'spec_helper'
 describe Gitlab::Ci::Config::Node::Job do
   let(:entry) { described_class.new(config, name: :rspec) }
-  before { entry.process! }
+  before { entry.compose! }
   describe 'validations' do
     context 'when entry config value is correct' do

spec/lib/gitlab/ci/config/node/jobs_spec.rb

@@ -4,7 +4,7 @@ describe Gitlab::Ci::Config::Node::Jobs do
   let(:entry) { described_class.new(config) }
   describe 'validations' do
-    before { entry.process! }
+    before { entry.compose! }
     context 'when entry config value is correct' do
       let(:config) { { rspec: { script: 'rspec' } } }
@@ -47,8 +47,8 @@ describe Gitlab::Ci::Config::Node::Jobs do
     end
   end
-  context 'when valid job entries processed' do
-    before { entry.process! }
+  context 'when valid job entries composed' do
+    before { entry.compose! }
     let(:config) do
       { rspec: { script: 'rspec' },

spec/lib/gitlab/ci/config/node/script_spec.rb

@@ -3,9 +3,7 @@ require 'spec_helper'
 describe Gitlab::Ci::Config::Node::Script do
   let(:entry) { described_class.new(config) }
-  describe '#process!' do
-    before { entry.process! }
-
+  describe 'validations' do
     context 'when entry config value is correct' do
       let(:config) { ['ls', 'pwd'] }