-
- Downloads
Merge branch '22481-honour-issue-visibility-for-groups' into 'security'
Honour issue and merge request visibility in their respective finders This MR fixes a security issue with the IssuesFinder and MergeRequestFinder where they would return items the user did not have permission to see. This was most visible on the issue and merge requests page for a group containing projects that had set their issues or merge requests to "private". Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/22481 See merge request !2000
Showing
- app/finders/issuable_finder.rb 14 additions, 19 deletionsapp/finders/issuable_finder.rb
- app/models/concerns/issuable.rb 5 additions, 1 deletionapp/models/concerns/issuable.rb
- app/models/project.rb 32 additions, 2 deletionsapp/models/project.rb
- app/models/project_feature.rb 11 additions, 3 deletionsapp/models/project_feature.rb
- spec/features/groups/issues_spec.rb 8 additions, 0 deletionsspec/features/groups/issues_spec.rb
- spec/features/groups/merge_requests_spec.rb 8 additions, 0 deletionsspec/features/groups/merge_requests_spec.rb
- spec/models/concerns/issuable_spec.rb 5 additions, 0 deletionsspec/models/concerns/issuable_spec.rb
- spec/support/project_features_apply_to_issuables_shared_examples.rb 56 additions, 0 deletions...rt/project_features_apply_to_issuables_shared_examples.rb
Loading