-
- Downloads
There was a problem fetching the pipeline summary.
Refactor Participable
There are several changes to this module: 1. The use of an explicit stack in Participable#participants 2. Proc behaviour has been changed 3. Batch permissions checking == Explicit Stack Participable#participants no longer uses recursion to process "self" and all child objects, instead it uses an Array and processes objects in breadth-first order. This allows us to for example create a single Gitlab::ReferenceExtractor instance and pass this to any Procs. Re-using a ReferenceExtractor removes the need for running potentially many SQL queries every time a Proc is called on a new object. == Proc Behaviour Changed Previously a Proc in Participable was expected to return an Array of User instances. This has been changed and instead it's now expected that a Proc modifies the Gitlab::ReferenceExtractor passed to it. The return value of the Proc is ignored. == Permissions Checking The method Participable#participants uses Ability.users_that_can_read_project to check if the returned users have access to the project of "self" _without_ running multiple SQL queries for every user.
parent
35e977d6
Branches
Tags
Pipeline #
Showing
- app/models/ability.rb 22 additions, 0 deletionsapp/models/ability.rb
- app/models/commit.rb 16 additions, 7 deletionsapp/models/commit.rb
- app/models/concerns/issuable.rb 6 additions, 2 deletionsapp/models/concerns/issuable.rb
- app/models/concerns/participable.rb 53 additions, 41 deletionsapp/models/concerns/participable.rb
- app/models/issue.rb 13 additions, 10 deletionsapp/models/issue.rb
- app/models/note.rb 1 addition, 1 deletionapp/models/note.rb
- app/models/project_snippet.rb 2 additions, 1 deletionapp/models/project_snippet.rb
- app/models/snippet.rb 6 additions, 1 deletionapp/models/snippet.rb
- spec/models/ability_spec.rb 117 additions, 0 deletionsspec/models/ability_spec.rb
- spec/models/commit_range_spec.rb 23 additions, 0 deletionsspec/models/commit_range_spec.rb
- spec/models/commit_spec.rb 37 additions, 1 deletionspec/models/commit_spec.rb
- spec/models/concerns/participable_spec.rb 83 additions, 0 deletionsspec/models/concerns/participable_spec.rb
- spec/models/issue_spec.rb 38 additions, 0 deletionsspec/models/issue_spec.rb
- spec/models/merge_request_spec.rb 24 additions, 0 deletionsspec/models/merge_request_spec.rb
- spec/models/note_spec.rb 23 additions, 2 deletionsspec/models/note_spec.rb
- spec/models/snippet_spec.rb 27 additions, 0 deletionsspec/models/snippet_spec.rb
Loading
Please register or sign in to comment